Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly handle const columns in DistinctTransfom #62250

Merged
merged 1 commit into from
Apr 4, 2024
Merged

Correctly handle const columns in DistinctTransfom #62250

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions src/Processors/Transforms/DistinctTransform.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@ void DistinctTransform::transform(Chunk & chunk)

/// Convert to full column, because SetVariant for sparse column is not implemented.
convertToFullIfSparse(chunk);
convertToFullIfConst(chunk);

const auto num_rows = chunk.getNumRows();
auto columns = chunk.detachColumns();
Expand Down
1 change: 1 addition & 0 deletions tests/queries/0_stateless/03033_distinct_transform_const_columns.reference
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
0 0
1 change: 1 addition & 0 deletions tests/queries/0_stateless/03033_distinct_transform_const_columns.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
SELECT DISTINCT COALESCE(COALESCE('') = toNullable('b3'), toUInt128(toNullable(2)), 2, 2, toLowCardinality(2), 2, 2, 2, toUInt128(toNullable(2)), materialize(2), toUInt128(2), 2, 2), COALESCE(COALESCE(COALESCE(materialize(''))) = 'b3', 2, 2, 2, toLowCardinality(2), toUInt128(2), 2, 2, 2, materialize(toUInt256(2)), 2, 2, 2) FROM numbers(100000);