New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added nano- micro- milliseconds unit for date_trunc
#62335
Conversation
This is an automated comment for commit dcf8bff with description of existing statuses. It's updated for the latest CI running ❌ Click here to open a full report in a separate page
Successful checks
|
date_trunc
Also, add tests for times before the Unix epoch, e.g. 1969. It is different because the underlying values are negative and there is a chance that fractions can be calculated incorrectly. |
The thing is that new time units work OK with times before the Unix epoch, but bigger time units return strange results. Some of them return 1970-01-01: https://fiddle.clickhouse.com/0f8c3b48-252d-43ac-ab23-7b94fc8e6f3e, some of them return strange results: https://fiddle.clickhouse.com/f85fd340-a496-4678-a859-9e66091d58f4. I will make an issue about that. upd: #62345 |
This requires investigation 🚀
Please merge with master ❤️ |
ffeec29
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Added nano- micro- milliseconds unit for date_trunc
Documentation entry for user-facing changes
Modify your CI run:
NOTE: If your merge the PR with modified CI you MUST KNOW what you are doing
NOTE: Checked options will be applied if set before CI RunConfig/PrepareRunConfig step
Include tests (required builds will be added automatically):
Exclude tests:
Extra options:
Only specified batches in multi-batch jobs: