New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
set correct defaults for s3 storage and backups #62648
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robot-ch-test-poll1
added
the
pr-improvement
Pull request with some product improvements
label
Apr 15, 2024
This is an automated comment for commit f03891d with description of existing statuses. It's updated for the latest CI running ❌ Click here to open a full report in a separate page
Successful checks
|
davenger
approved these changes
Apr 15, 2024
robot-ch-test-poll2
added
the
pr-synced-to-cloud
The PR is synced to the cloud repo
label
Apr 15, 2024
This was referenced Apr 15, 2024
robot-ch-test-poll4
added a commit
that referenced
this pull request
Apr 15, 2024
…a0d3e403ab4dc1248427ab499d892 Cherry pick #62648 to 24.3: set correct defaults for s3 storage and backups
robot-clickhouse
added a commit
that referenced
this pull request
Apr 15, 2024
robot-clickhouse-ci-2
added a commit
that referenced
this pull request
Apr 15, 2024
Backport #62648 to 24.3: set correct defaults for s3 storage and backups
robot-ch-test-poll
added
pr-backports-created
Backport PRs are successfully created, it won't be processed by CI script anymore
pr-backports-created-cloud
labels
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
pr-backports-created
Backport PRs are successfully created, it won't be processed by CI script anymore
pr-backports-created-cloud
pr-improvement
Pull request with some product improvements
pr-must-backport-cloud
pr-synced-to-cloud
The PR is synced to the cloud repo
v24.2-must-backport
v24.3-must-backport
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up #62249
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
s3 storage and backups also need the same default keep alive settings as s3 disk
Documentation entry for user-facing changes
Modify your CI run:
NOTE: If your merge the PR with modified CI you MUST KNOW what you are doing
NOTE: Checked options will be applied if set before CI RunConfig/PrepareRunConfig step
Include tests (required builds will be added automatically):
Exclude tests:
Extra options:
Only specified batches in multi-batch jobs: