Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MaterializedMySQLSyncThread.cpp #62793

Closed
wants to merge 1 commit into from

Conversation

kolya7k
Copy link
Contributor

@kolya7k kolya7k commented Apr 19, 2024

mysql 8.3.0+ doesn't have log_bin_use_v1_row_events variable

mysql 8.3.0+ doesn't have log_bin_use_v1_row_events variable
@CLAassistant
Copy link

CLAassistant commented Apr 19, 2024

CLA assistant check
All committers have signed the CLA.

@alexey-milovidov alexey-milovidov added the can be tested Allows running workflows for external contributors label Apr 20, 2024
@alexey-milovidov alexey-milovidov self-assigned this Apr 20, 2024
@robot-ch-test-poll1
Copy link
Contributor

robot-ch-test-poll1 commented Apr 20, 2024

This is an automated comment for commit af103c8 with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Check nameDescriptionStatus
Mergeable CheckChecks if all other necessary checks are successful❌ failure
PR CheckThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS❌ failure
Successful checks
Check nameDescriptionStatus
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR✅ success

@Slach
Copy link
Contributor

Slach commented Apr 20, 2024

@kolya7k thanks you for your efforts

@alexey-milovidov
Copy link
Member

PR Check — Changelog category is empty

@alexey-milovidov alexey-milovidov added the close in a month if not active This will be closed in case of no information label Apr 20, 2024
@alexey-milovidov
Copy link
Member

Changelog category is empty

@alexey-milovidov
Copy link
Member

@kolya7k it couldn't be merged due to the failed changelog check.

@alexey-milovidov
Copy link
Member

@Slach, if you want to help, open another pull request with the same changes.

Slach added a commit to Slach/ClickHouse that referenced this pull request Apr 29, 2024
@Slach
Copy link
Contributor

Slach commented Apr 30, 2024

@kolya7k let's close this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
can be tested Allows running workflows for external contributors close in a month if not active This will be closed in case of no information
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants