Fix crash on CAST exotic types to Decimal #6297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #6116 |
|
Don't understand - why is was crashing and whether the root cause was fixed. |
abyss7
pushed a commit
to abyss7/ClickHouse
that referenced
this pull request
Sep 6, 2019
Fix crash on CAST exotic types to Decimal (cherry picked from commit 12a8bf2)
KochetovNicolai
pushed a commit
that referenced
this pull request
Sep 20, 2019
Fix crash on CAST exotic types to Decimal (cherry picked from commit 12a8bf2)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Category (leave one):
Short description (up to few sentences):
Fix crash when casting types to Decimal that do not support it. Throw exception instead.