Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry pick #62811 to 24.3: Fix FINAL modifier is not respected in CTE with analyzer #62992

Conversation

robot-clickhouse-ci-2
Copy link
Contributor

Original pull-request #62811

This pull-request is a first step of an automated backporting.
It contains changes similar to calling git cherry-pick locally.
If you intend to continue backporting the changes, then resolve all conflicts if any.
Otherwise, if you do not want to backport them, then just close this pull-request.

The check results does not matter at this step - you can safely ignore them.

Note

This pull-request will be merged automatically. Please, do not merge it manually (but if you accidentally did, nothing bad will happen).

Troubleshooting

If the PR was manually reopened after being closed

If this PR is stuck (i.e. not automatically merged after one day), check #62811 for pr-backports-created label and delete it.

Manually merging will do nothing. The pr-backports-created label prevents the original PR #62811 from being processed.

If the conflicts were resolved in a wrong way

If this cherry-pick PR is completely screwed by a wrong conflicts resolution, and you want to recreate it:

  • delete the pr-cherrypick label from the PR
  • delete this branch from the repository

You also need to check the original PR #62811 for pr-backports-created, and delete if it's presented there

canhld94 and others added 4 commits April 20, 2024 02:18
Signed-off-by: Duc Canh Le <duccanh.le@ahrefs.com>
Signed-off-by: Duc Canh Le <duccanh.le@ahrefs.com>
Signed-off-by: Duc Canh Le <duccanh.le@ahrefs.com>
Fix FINAL modifier is not respected in CTE with analyzer
@robot-clickhouse-ci-2 robot-clickhouse-ci-2 added pr-cherrypick Cherry-pick of merge-commit before backporting. Do not use manually - automated use only! do not test disable testing on pull request labels Apr 25, 2024
@robot-clickhouse-ci-2 robot-clickhouse-ci-2 merged commit 7da6168 into backport/24.3/62811 Apr 25, 2024
165 of 177 checks passed
@robot-clickhouse-ci-2 robot-clickhouse-ci-2 deleted the cherrypick/24.3/e1da9114fb73f6c2ecc28bbacb57e068e436cdf9 branch April 25, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do not test disable testing on pull request pr-cherrypick Cherry-pick of merge-commit before backporting. Do not use manually - automated use only!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants