New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not remove server constants from GROUP BY key for secondary query. #63047
Do not remove server constants from GROUP BY key for secondary query. #63047
Conversation
This is an automated comment for commit 48213c2 with description of existing statuses. It's updated for the latest CI running ❌ Click here to open a full report in a separate page
Successful checks
|
@@ -100,7 +102,7 @@ std::optional<AggregationAnalysisResult> analyzeAggregation(const QueryTreeNodeP | |||
auto is_constant_key = grouping_set_key_node->as<ConstantNode>() != nullptr; | |||
group_by_with_constant_keys |= is_constant_key; | |||
|
|||
if (is_constant_key && !aggregates_descriptions.empty()) | |||
if (!is_secondary_query && is_constant_key && !aggregates_descriptions.empty()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing a comment.
…0564243dfa04f205874e9e9aa83b5 Cherry pick #63047 to 24.3: Do not remove server constants from GROUP BY key for secondary query.
… key for secondary query.
Backport #63047 to 24.3: Do not remove server constants from GROUP BY key for secondary query.
@alexey-milovidov, @KochetovNicolai, CI failures were related, it breaks |
Reproduces with:
This breaks CI, so we need to fix it or revert |
Minimized:
|
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix
Not found column in block
error for distributed queries with server-side constants inGROUP BY
key. Fixes #62682