-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recursive CTE data race fix #63125
Recursive CTE data race fix #63125
Conversation
This is an automated comment for commit ff1c002 with description of existing statuses. It's updated for the latest CI running ❌ Click here to open a full report in a separate page
Successful checks
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for the quick fix @kitaisreal
I've made 2 small changes:
- Use TSA annotations which force acquiring the mutex in several places (correctly), so we don't need to copy the object. I don't expect there to be any mutex contention since logging should not be happening with active pipelines (but tsan will still complain if we don't).
- Some changes in the test to avoid flakiness (session_timezone) and my bad environment (enable_global_with_statement).
Let's confirm everything is green now and merge
Thanks. Let's wait for CI checks and merge. |
Changelog category (leave one):