-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parallel replicas feature is Beta #63151
base: master
Are you sure you want to change the base?
Conversation
This is an automated comment for commit e73981e with description of existing statuses. It's updated for the latest CI running ❌ Click here to open a full report in a separate page
Successful checks
|
Currently, there are four modes for parallel replicas:
Confusingly, the "sample key" mode is available even without We should introduce a new setting "parallel_replicas_mode" which will decide between these modes. |
@@ -31,7 +31,7 @@ test1() { | |||
GROUP BY CounterID, URL, EventDate | |||
ORDER BY URL, EventDate | |||
LIMIT 5 OFFSET 10 | |||
SETTINGS optimize_aggregation_in_order = 1, enable_memory_bound_merging_of_aggregation_results = 1, allow_experimental_parallel_reading_from_replicas = 1, parallel_replicas_for_non_replicated_merge_tree = 1, max_parallel_replicas = 3" | |||
SETTINGS optimize_aggregation_in_order = 1, enable_memory_bound_merging_of_aggregation_results = 1, use_parallel_replicas = 1, parallel_replicas_for_non_replicated_merge_tree = 1, max_parallel_replicas = 3" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's have at least one test with old name for compatibility check
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@alexey-milovidov Parallel replicas modes 1, 3, and 4 are currently working on top of distributed table. While task-based parallel replicas work on top of MergeTree. We should unify this as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's make the parallel replicas with custom key work on top of MergeTree first and introduce the setting parallel_replicas_mode
: #63521
Unifying settings and implementing custom key on top of MergeTree are 2 different things and can be done independently |
81445ce
to
e73981e
Compare
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
The "parallel replicas" feature is no longer experimental and it is now in beta. The setting
allow_experimental_parallel_replicas
is renamed touse_parallel_replicas
.Modify your CI run:
NOTE: If your merge the PR with modified CI you MUST KNOW what you are doing
NOTE: Checked options will be applied if set before CI RunConfig/PrepareRunConfig step
Include tests (required builds will be added automatically):
Exclude tests:
Extra options:
Only specified batches in multi-batch jobs: