-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add changeDate*
functions
#63186
Add changeDate*
functions
#63186
Conversation
Ubuntu seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
This is an automated comment for commit cdd99a7 with description of existing statuses. It's updated for the latest CI running ❌ Click here to open a full report in a separate page
Successful checks
|
Please also include some docs for expected behavior of the functions. E.g.: their basic functionality and how the different errors are handled. |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
I thought about how out-of-bounds inputs should be handled (see the SQL test). The ClickHouse philosophy is to give no guarantees about the result in such cases (basically undefined behavior). The docs currently don't state that explicitly, but I think this is okay as undefined behavior is the default behavior for similar functions. With regards to testing, it is nice to produce at least a deterministic output value. This is luckily the case right now. Imho, this PR can be merged once tests are green. |
@cucumber95 Could you please sign the CLA? It somehow did not pick up your first commit which you made under the name "ubuntu". --> https://cla-assistant.io/ClickHouse/ClickHouse?pullRequest=63186 |
@cucumber95 This PR is good but without signed CLA we can unfortunately not continue. I'll close this PR for now. It would be great if you could pick it up again. |
Fixes #36470
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Add SQL functions
changeYear
,changeMonth
,changeDay
,changeHour
,changeMinute
,changeSecond
.