Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve builds' profiling upload #63325

Merged
merged 5 commits into from
Jun 4, 2024
Merged

Improve builds' profiling upload #63325

merged 5 commits into from
Jun 4, 2024

Conversation

Felixoid
Copy link
Member

@Felixoid Felixoid commented May 3, 2024

Changelog category (leave one):

  • CI Fix or Improvement (changelog entry is not required)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Reduce time-to-insert profiling data in case of logs cluster issues.

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

Modify your CI run

NOTE: If your merge the PR with modified CI you MUST KNOW what you are doing
NOTE: Checked options will be applied if set before CI RunConfig/PrepareRunConfig step

Include tests (required builds will be added automatically):

  • Fast test
  • Integration Tests
  • Stateless tests
  • Stateful tests
  • Unit tests
  • Performance tests
  • All with ASAN
  • All with TSAN
  • All with Analyzer
  • All with Azure
  • Add your option here

Exclude tests:

  • Fast test
  • Integration Tests
  • Stateless tests
  • Stateful tests
  • Performance tests
  • All with ASAN
  • All with TSAN
  • All with MSAN
  • All with UBSAN
  • All with Coverage
  • All with Aarch64
  • Add your option here

Extra options:

  • ASAN package
  • binary release
  • do not test (only style check)
  • disable merge-commit (no merge from master before tests)
  • disable CI cache (job reuse)

Only specified batches in multi-batch jobs:

  • 1
  • 2
  • 3
  • 4

@Felixoid Felixoid added the do not test disable testing on pull request label May 3, 2024
@Felixoid
Copy link
Member Author

Felixoid commented May 3, 2024

For the context, now "Exclude tests" for example, "All with ASan", "All with MSan", disables ASan/MSan builds, and then the build check will be incomplete.

@Felixoid Felixoid changed the title [WIP] Reliable build report Improve builds' profiling upload Jun 3, 2024
@robot-ch-test-poll3
Copy link
Contributor

robot-ch-test-poll3 commented Jun 3, 2024

This is an automated comment for commit f46376d with description of existing statuses. It's updated for the latest CI running

⏳ Click here to open a full report in a separate page

Check nameDescriptionStatus
A SyncIf it fails, ask a maintainer for help⏳ pending
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR⏳ pending
Successful checks
Check nameDescriptionStatus
PR CheckThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success

@Felixoid Felixoid force-pushed the reliable-build-report branch 2 times, most recently from 8554eaf to 597285d Compare June 4, 2024 07:27
@maxknv
Copy link
Member

maxknv commented Jun 4, 2024

LGTM

@Felixoid
Copy link
Member Author

Felixoid commented Jun 4, 2024

It looks the tags somehow don't work. Let's launch ASAN build here and in the sync PR. What should I change?

@Felixoid Felixoid removed the do not test disable testing on pull request label Jun 4, 2024
@Felixoid Felixoid marked this pull request as ready for review June 4, 2024 12:52
@Felixoid Felixoid marked this pull request as draft June 4, 2024 13:12
@Felixoid Felixoid marked this pull request as ready for review June 4, 2024 13:44
@Felixoid Felixoid enabled auto-merge June 4, 2024 13:45
@Felixoid Felixoid added this pull request to the merge queue Jun 4, 2024
Merged via the queue into master with commit d02197e Jun 4, 2024
7 of 19 checks passed
@Felixoid Felixoid deleted the reliable-build-report branch June 4, 2024 14:04
@robot-ch-test-poll1 robot-ch-test-poll1 added the pr-synced-to-cloud The PR is synced to the cloud repo label Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-ci pr-synced-to-cloud The PR is synced to the cloud repo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants