Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PostgreSQL query translation layer #63382

Closed
wants to merge 37 commits into from

Conversation

seshWCS
Copy link
Contributor

@seshWCS seshWCS commented May 5, 2024

Changelog category (leave one):

  • New Feature
  • Improvement
  • Performance Improvement
  • Backward Incompatible Change
  • Build/Testing/Packaging Improvement
  • Documentation (changelog entry is not required)
  • Bug Fix (user-visible misbehavior in an official stable release)
  • CI Fix or Improvement (changelog entry is not required)
  • Not for changelog (changelog entry is not required)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

...

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

Modify your CI run

NOTE: If your merge the PR with modified CI you MUST KNOW what you are doing
NOTE: Checked options will be applied if set before CI RunConfig/PrepareRunConfig step

Include tests (required builds will be added automatically):

  • Fast test
  • Integration Tests
  • Stateless tests
  • Stateful tests
  • Unit tests
  • Performance tests
  • All with ASAN
  • All with TSAN
  • All with Analyzer
  • All with Azure
  • Add your option here

Exclude tests:

  • Fast test
  • Integration Tests
  • Stateless tests
  • Stateful tests
  • Performance tests
  • All with ASAN
  • All with TSAN
  • All with MSAN
  • All with UBSAN
  • All with Coverage
  • All with Aarch64
  • Add your option here

Extra options:

  • do not test (only style check)
  • disable merge-commit (no merge from master before tests)
  • disable CI cache (job reuse)

Only specified batches in multi-batch jobs:

  • 1
  • 2
  • 3
  • 4

@seshWCS seshWCS marked this pull request as draft May 5, 2024 15:08
@CLAassistant
Copy link

CLAassistant commented May 5, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 3 committers have signed the CLA.

✅ seshWCS
❌ Ubuntu
❌ nikitakeba


Ubuntu seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@alexey-milovidov alexey-milovidov changed the title PostgresQL integration PostgreSQL integration May 5, 2024
Copy link

clickhouse-ci bot commented May 5, 2024

This is an automatic comment. The PR descriptions does not match the template.

Please, edit it accordingly.

The error is: More than one changelog category specified: 'New Feature', 'Improvement'

Ubuntu and others added 2 commits May 6, 2024 03:00
@nikitamikhaylov nikitamikhaylov added the can be tested Allows running workflows for external contributors label May 6, 2024
@robot-ch-test-poll3 robot-ch-test-poll3 added pr-feature Pull request with new product feature submodule changed At least one submodule changed in this PR. labels May 6, 2024
@robot-ch-test-poll3
Copy link
Contributor

robot-ch-test-poll3 commented May 6, 2024

This is an automated comment for commit 74be637 with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Check nameDescriptionStatus
PR CheckThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS❌ failure

@alexey-milovidov alexey-milovidov changed the title PostgreSQL integration PostgreSQL query translation layer May 27, 2024
Copy link

clickhouse-ci bot commented May 27, 2024

This is an automatic comment. The PR descriptions does not match the template.

Please, edit it accordingly.

The error is: More than one changelog category specified: 'New Feature', 'Improvement'

@@ -0,0 +1,9 @@
SET dialect = 'postgresql'

SELECT 1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All four of these queries work in ClickHouse as well.
It means that the test does not show anything about the PostgreSQL query language.


auto res = pg_query_parse(query.data());

String json = String(res.parse_tree);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is pointless to obtain the AST in JSON and then parse it back.
We probably could work on the tree representation directly to avoid this serialization/deserialization step.

@alexey-milovidov
Copy link
Member

This represents, at best, 30% of what makes practical sense.
Unless you want to continue working on this project, the PR has a low chance of being merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
can be tested Allows running workflows for external contributors pr-feature Pull request with new product feature submodule changed At least one submodule changed in this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants