Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add loop() table function #63452

Merged
merged 17 commits into from
May 30, 2024
Merged

Add loop() table function #63452

merged 17 commits into from
May 30, 2024

Conversation

sarielwxm
Copy link
Contributor

@sarielwxm sarielwxm commented May 7, 2024

Fixes #52765

Changelog category (leave one):

  • New Feature

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Added a new table function loop to support returning query results in an infinite loop.

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

Modify your CI run

NOTE: If your merge the PR with modified CI you MUST KNOW what you are doing
NOTE: Checked options will be applied if set before CI RunConfig/PrepareRunConfig step

Include tests (required builds will be added automatically):

  • Fast test
  • Integration Tests
  • Stateless tests
  • Stateful tests
  • Unit tests
  • Performance tests
  • All with ASAN
  • All with TSAN
  • All with Analyzer
  • All with Azure
  • Add your option here

Exclude tests:

  • Fast test
  • Integration Tests
  • Stateless tests
  • Stateful tests
  • Performance tests
  • All with ASAN
  • All with TSAN
  • All with MSAN
  • All with UBSAN
  • All with Coverage
  • All with Aarch64
  • Add your option here

Extra options:

  • do not test (only style check)
  • disable merge-commit (no merge from master before tests)
  • disable CI cache (job reuse)

Only specified batches in multi-batch jobs:

  • 1
  • 2
  • 3
  • 4

@CLAassistant
Copy link

CLAassistant commented May 7, 2024

CLA assistant check
All committers have signed the CLA.

@alexey-milovidov alexey-milovidov added the can be tested Allows running workflows for external contributors label May 7, 2024
@robot-ch-test-poll2 robot-ch-test-poll2 added pr-feature Pull request with new product feature submodule changed At least one submodule changed in this PR. labels May 7, 2024
@robot-ch-test-poll2
Copy link
Contributor

robot-ch-test-poll2 commented May 7, 2024

This is an automated comment for commit 0f952cc with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Check nameDescriptionStatus
A SyncThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS⏳ pending
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR⏳ pending
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests❌ failure
Mergeable CheckChecks if all other necessary checks are successful⏳ pending
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors❌ failure
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts❌ failure
Successful checks
Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help✅ success
ClickBenchRuns [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table✅ success
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker keeper imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docker server imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docs checkBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integration tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
PR CheckThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success

@divanik divanik self-assigned this May 7, 2024
@divanik
Copy link
Member

divanik commented May 7, 2024

Hi, @sarielwxm. Thank you for your contribution to Clickhouse! I will be glad to review your PR. Firstly, I'd like to ask you to add the example output after execution of this table function that demonstrates its typical behaviour to the documentation. Secondly, could you please write a fast test that checks desired behaviour of the function? After these steps I will be able to continue the reviewing process

@sarielwxm
Copy link
Contributor Author

Hi, @sarielwxm. Thank you for your contribution to Clickhouse! I will be glad to review your PR. Firstly, I'd like to ask you to add the example output after execution of this table function that demonstrates its typical behaviour to the documentation. Secondly, could you please write a fast test that checks desired behaviour of the function? After these steps I will be able to continue the reviewing process

Sure. I have already tested it locally. But I have a problem because this table function implements an infinite loop over the query results and it seems difficult to represent the example output. Could you please give me some suggestions? Much appreciated!

@divanik
Copy link
Member

divanik commented May 8, 2024

Sure. I have already tested it locally. But I have a problem because this table function implements an infinite loop over the query results and it seems difficult to represent the example output. Could you please give me some suggestions? Much appreciated!

Could you use LIMIT operator to bound the output of the loop function?

@sarielwxm
Copy link
Contributor Author

Could you use LIMIT operator to bound the output of the loop function?

Got it. It's useful.

contrib/azure Outdated Show resolved Hide resolved
@robot-ch-test-poll4 robot-ch-test-poll4 removed the submodule changed At least one submodule changed in this PR. label May 16, 2024
@divanik
Copy link
Member

divanik commented May 21, 2024

❌ Click here to open a full report on a separate page - you can find a report, why some CI tests failed. Tests that you added shouldn't be flaky. But there are some flaky tests in our repository (tests that fail in master CI, and they can fail in your PR as well). You can find them at https://aretestsgreenyet.com. If you see that a test fail both in your PR and master, you can forget about it more or less. But in our case, the new test is flaky that's why it should be fixed before PR merge. Everything else looks good to me

Copy link
Member

@divanik divanik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is need to fix the flaky test

Copy link
Member

@divanik divanik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. There are some issues with CI, I will try to resolve them by myself

@divanik divanik added this pull request to the merge queue May 30, 2024
Merged via the queue into ClickHouse:master with commit 2520e5c May 30, 2024
237 of 248 checks passed
@robot-ch-test-poll4 robot-ch-test-poll4 added the pr-synced-to-cloud The PR is synced to the cloud repo label May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
can be tested Allows running workflows for external contributors pr-feature Pull request with new product feature pr-synced-to-cloud The PR is synced to the cloud repo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Table function loop
6 participants