-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
io_uring: refactor get reader from context #63475
io_uring: refactor get reader from context #63475
Conversation
This is an automated comment for commit b97bf45 with description of existing statuses. It's updated for the latest CI running ❌ Click here to open a full report in a separate page
Successful checks
|
@tomershafir please check failed fast test |
449c836
to
abd425f
Compare
abd425f
to
b97bf45
Compare
@kssenii fixed, sorry had problems with local build |
|
||
std::unique_ptr<IOUringReader> createIOUringReader() | ||
{ | ||
return std::make_unique<IOUringReader>(512); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better turn this into a constant to avoid the magic number.
Alterantively, IOUringReader
could have a default ctor that initializes the entry count with 512.
looks unrelated
|
42c984d
Refactor IOUringReader creation logic, similar to
src/Disks/IO/getThreadPoolReader.h
, to remove code duplication.Changelog category (leave one):