-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: empty used_dictionaries in system.query_log #63487
Merged
jsc0218
merged 2 commits into
ClickHouse:master
from
korowa:fix-used-dictionaries-logging
May 20, 2024
Merged
fix: empty used_dictionaries in system.query_log #63487
jsc0218
merged 2 commits into
ClickHouse:master
from
korowa:fix-used-dictionaries-logging
May 20, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Algunenano
added
the
can be tested
Allows running workflows for external contributors
label
May 7, 2024
korowa
force-pushed
the
fix-used-dictionaries-logging
branch
from
May 7, 2024 18:19
9577d1c
to
48455c2
Compare
robot-ch-test-poll3
added
the
pr-bugfix
Pull request with bugfix, not backported by default
label
May 7, 2024
This is an automated comment for commit a365c36 with description of existing statuses. It's updated for the latest CI running ❌ Click here to open a full report in a separate page
Successful checks
|
korowa
force-pushed
the
fix-used-dictionaries-logging
branch
from
May 8, 2024 06:30
48455c2
to
e7ebb96
Compare
korowa
changed the title
fix: empty used_dictionaies in system.query_log
fix: empty used_dictionaries in system.query_log
May 8, 2024
korowa
force-pushed
the
fix-used-dictionaries-logging
branch
from
May 8, 2024 19:26
e7ebb96
to
eedef6d
Compare
jsc0218
approved these changes
May 14, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
May 14, 2024
@jsc0218 should I take any action regarding this PR now (e.g. rerun CI)? |
@korowa thanks for reminding, not sure why the pr is not merged, let me try again. |
Merged
via the queue into
ClickHouse:master
with commit May 20, 2024
41dec5e
226 of 235 checks passed
robot-clickhouse-ci-2
added
the
pr-synced-to-cloud
The PR is synced to the cloud repo
label
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
can be tested
Allows running workflows for external contributors
pr-bugfix
Pull request with bugfix, not backported by default
pr-synced-to-cloud
The PR is synced to the cloud repo
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix
system.query_log.used_dictionaries
loggingDocumentation entry for user-facing changes
Modify your CI run
NOTE: If your merge the PR with modified CI you MUST KNOW what you are doing
NOTE: Checked options will be applied if set before CI RunConfig/PrepareRunConfig step
Include tests (required builds will be added automatically):
Exclude tests:
Extra options:
Only specified batches in multi-batch jobs:
Closes #58843
Note: used_dictionaries now contains fully qualified object names for SQL-created dictionaries (instead of UUIDs). This part can be reverted if current behaviour with logging dictionary UUIDs is preferrable.