-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow cast from Array(Nothing) to Map(Nothing, Nothing) #63753
Allow cast from Array(Nothing) to Map(Nothing, Nothing) #63753
Conversation
This is an automated comment for commit ca2f6ff with description of existing statuses. It's updated for the latest CI running ❌ Click here to open a full report in a separate page
Successful checks
|
@@ -3770,6 +3771,12 @@ class FunctionCast final : public IFunctionBase | |||
} | |||
else if (const auto * from_array = typeid_cast<const DataTypeArray *>(from_type_untyped.get())) | |||
{ | |||
if (typeid_cast<const DataTypeNothing *>(from_array->getNestedType().get())) | |||
return [nested = to_type->getNestedType()](ColumnsWithTypeAndName &, const DataTypePtr &, const ColumnNullable *, size_t size) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we check that to_type
is also using Nothing
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be checked by getReturnType
…436c53763c8f54cfafd67faf90bd2 Cherry pick #63753 to 24.4: Allow cast from Array(Nothing) to Map(Nothing, Nothing)
Backport #63753 to 24.4: Allow cast from Array(Nothing) to Map(Nothing, Nothing)
…436c53763c8f54cfafd67faf90bd2 Cherry pick #63753 to 24.3: Allow cast from Array(Nothing) to Map(Nothing, Nothing)
Backport #63753 to 24.3: Allow cast from Array(Nothing) to Map(Nothing, Nothing)
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix
Not found column
andCAST AS Map from array requires nested tuple of 2 elements
exceptions for distributed queries which useMap(Nothing, Nothing)
type. Fixes #63637