-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Files without shebang have mime 'text/plain' or 'inode/x-empty' #64062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an automated comment for commit d6a16b8 with description of existing statuses. It's updated for the latest CI running ✅ Click here to open a full report in a separate page Successful checks
|
This was referenced May 17, 2024
Closed
Closed
robot-clickhouse-ci-1
added a commit
that referenced
this pull request
May 17, 2024
…b874252b5d070708fdee2f761b2e6 Cherry pick #64062 to 24.3: Files without shebang have mime 'text/plain' or 'inode/x-empty'
robot-clickhouse-ci-1
added a commit
that referenced
this pull request
May 17, 2024
…b874252b5d070708fdee2f761b2e6 Cherry pick #64062 to 24.4: Files without shebang have mime 'text/plain' or 'inode/x-empty'
robot-clickhouse-ci-1
added a commit
that referenced
this pull request
May 17, 2024
Backport #64062 to 24.3: Files without shebang have mime 'text/plain' or 'inode/x-empty'
Felixoid
added a commit
that referenced
this pull request
May 19, 2024
Backport #64062 to 24.4: Files without shebang have mime 'text/plain' or 'inode/x-empty'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
do not test
disable testing on pull request
pr-backports-created
Backport PRs are successfully created, it won't be processed by CI script anymore
pr-backports-created-cloud
pr-ci
pr-must-backport
Pull request should be backported intentionally. Use this label with great care!
pr-must-backport-cloud
pr-synced-to-cloud
The PR is synced to the cloud repo
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
The mime type is not 100% reliable for Python and shell scripts without shebangs; add a check for file extension.
Note
In #62652 the new file was not detected as a python file. Here's why:
Documentation entry for user-facing changes
Modify your CI run
NOTE: If your merge the PR with modified CI you MUST KNOW what you are doing
NOTE: Checked options will be applied if set before CI RunConfig/PrepareRunConfig step
Include tests (required builds will be added automatically):
Exclude tests:
Extra options:
Only specified batches in multi-batch jobs: