Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix behavior low cardinality setting in creating materialized view (Fix #6293) #6428

Merged
merged 1 commit into from Aug 10, 2019

Conversation

stavrolia
Copy link
Contributor

@stavrolia stavrolia commented Aug 9, 2019

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

For changelog. Remove if this is non-significant change.
Fix #6293
Category (leave one):

  • Bug Fix. Small one.

Short description (up to few sentences):
Materialized view now could be created with any low cardinality types regardless to the setting about suspicious low cardinality types.

@alexey-milovidov alexey-milovidov added the pr-improvement Pull request with some product improvements label Aug 9, 2019
@den-crane
Copy link
Contributor

den-crane commented Aug 10, 2019

The main issue is not the "allow_suspicious_low_cardinality_types" but LowCardinality itself.

desc (select x='a' bool from (select toLowCardinality('a') x))
┌─name─┬─type──────────────────┬
│ bool │ LowCardinality(UInt8) │
└──────┴───────────────────────┴

EXPECTED:

┌─name─┬─type──┬
│ bool │ UInt8 │
└──────┴───────┴

@stavrolia
Copy link
Contributor Author

@den-crane, the idea of improvement of implicit casts of LowCardinality is good, but unfortunately it is very expensive because of current architecture. So, I think this change is enough for scope of this issue. Could you please create another one?

@den-crane
Copy link
Contributor

OK.
Done #6432

@stavrolia stavrolia merged commit dd6f483 into master Aug 10, 2019
@stavrolia stavrolia deleted the low-cardinality-setting-in-cast branch August 10, 2019 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-improvement Pull request with some product improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error on LowCardinality(String) to UInt64 conversion
3 participants