-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to load dashboards for system.dashboards from config #65555
base: master
Are you sure you want to change the base?
Conversation
This is an automated comment for commit 5f21f31 with description of existing statuses. It's updated for the latest CI running ❌ Click here to open a full report in a separate page
Successful checks
|
|
097aae0
to
541e118
Compare
Some CI issues, and no reasons in logs. Will do a rebase. |
One of the obvious reasons is to allow rendering them with readonly user, which is not possible right now, due to usage of merge() function there. Another one, is to add some custom metrics. Note, that once set, they overrides the default dashboards preset. Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
541e118
to
5f21f31
Compare
Test failures does not looks related. |
@serxa so does this PR waits something from my side? |
No, it just waits for CI to be green in private fork as well |
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Add ability to load dashboards for system.dashboards from config (once set, they overrides the default dashboards preset)
One of the obvious reasons is to allow rendering them with readonly user, which is not possible right now, due to usage of merge() function there.
Another one, is to add some custom metrics.
Follow-up for: #56771 (cc @serxa )