Fix some pvs reported issues #6837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filimonov
added
pr-bugfix
alexey-milovidov
approved these changes
Sep 6, 2019
abyss7
reviewed
Sep 6, 2019
| @@ -1222,8 +1222,8 @@ void Context::setCurrentQueryId(const String & query_id) | |||
| } words; | |||
| } random; | |||
|
|
|||
| random.words.a = thread_local_rng(); | |||
| random.words.b = thread_local_rng(); | |||
| random.words.a = thread_local_rng(); //-V656 | |||
There was a problem hiding this comment.
Suppresstion. It's required by PVS-Studio to be in exactly this format.
The only way is to write an additional describing comment in a line above, but it's too cumbersome to do it for every suppression.
nikitamikhaylov
pushed a commit
that referenced
this pull request
Sep 12, 2019
Fix some pvs reported issues (cherry picked from commit c90dfc1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One bug found by PVS Studio + 2 cosmetics
Category (leave one):
Detailed description (optional):
See commit messages