New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOCAPI-7743: CREATE TABLE AS table_function() docs. #6887
DOCAPI-7743: CREATE TABLE AS table_function() docs. #6887
Conversation
…CAPI-7743-create-table-as-table-function
…CAPI-7743-create-table-as-table-function
|
||
## allow_ddl {#settings_allow_ddl} | ||
|
||
Allows/denies [DDL](https://en.wikipedia.org/wiki/Data_definition_language) queries. | ||
Enables or disables [DDL](https://en.wikipedia.org/wiki/Data_definition_language) queries. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not about enabling, it's about disallowing some user to perform DDL, so it should be different from most other settings (like it was in previous version).
docs/en/query_language/select.md
Outdated
|
||
A table function may be specified instead of a table. For more information, see the section "Table functions". | ||
Instead of a table, the `SELECT` subquery may be specified in brackets. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
round brackets?
docs/en/query_language/select.md
Outdated
|
||
A table function may be specified instead of a table. For more information, see the section "Table functions". | ||
Instead of a table, the `SELECT` subquery may be specified in brackets. | ||
In this case, the subquery processing pipeline will be built into the processing pipeline of an external query. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this sentence is especially weird, we should probably rewrite the whole FROM section introduction by explaining possible options and explicitly going through them in order
@@ -1,8 +1,30 @@ | |||
# Table functions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
title case
Table functions can be specified in the FROM clause instead of the database and table names. | ||
Table functions can only be used if 'readonly' is not set. | ||
Table functions aren't related to other functions. | ||
Table function is a method of creating a table. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd use some different verb instead of "create" to avoid implying that it's permanent.
|
||
* [CREATE TABLE](../create.md#create-table-query) query. | ||
|
||
It's an alternative method of creating a table. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this doesn't explain alternative to what + it's as normal as just specifying columns and engine
|
||
* [FROM](../select.md#select-from) clause of the `SELECT` query. | ||
|
||
The method of creating a temporary table, that is deleted after the query finishes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's also unavailable from concurrent queries, so I'd just avoid mentioning "creating/deleting" in the first place
Co-Authored-By: Ivan Blinkov <github@blinkov.ru>
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Category (leave one):