Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build for Darwin #7149

Merged
merged 8 commits into from Oct 2, 2019
Merged

Fix build for Darwin #7149

merged 8 commits into from Oct 2, 2019

Conversation

abyss7
Copy link
Contributor

@abyss7 abyss7 commented Sep 30, 2019

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

For changelog. Remove if this is non-significant change.

Category (leave one):

  • Build/Testing/Packaging Improvement

@abyss7 abyss7 added the pr-build Pull request with build/testing/packaging improvement label Sep 30, 2019
@abyss7 abyss7 self-assigned this Sep 30, 2019
@abyss7 abyss7 merged commit 3819475 into ClickHouse:master Oct 2, 2019
@proller
Copy link
Contributor

proller commented Oct 2, 2019

All changes near ENABLE_.... should be reverted.

@@ -65,14 +65,19 @@ if (CMAKE_CROSSCOMPILING)
set (HAS_POST_2038_EXITCODE "0" CACHE STRING "Result from TRY_RUN" FORCE)
set (HAS_POST_2038_EXITCODE__TRYRUN_OUTPUT "" CACHE STRING "Output from TRY_RUN" FORCE)

# CMake < 3.13 doesn't respect same-name variables as values for options.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you don't know how to make such things with cmake you can ask colleagues. Will be fixed here bf2a265#diff-6f5216ab1e6a5d2983a9841326e86958R69

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-build Pull request with build/testing/packaging improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants