Ignore non-convertible values at any depth on the right side of the IN operator #7283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akuzm
force-pushed
the
aku/in-unconvertible
branch
from
e45409f
to
2172e2d
Compare
|
Please update the tests. |
operator. The values that are not convertible to the left argument type can't match anyway, so it is safe to discard them.
akuzm
force-pushed
the
aku/in-unconvertible
branch
from
2172e2d
to
160d8a6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The values that are not convertible to the left argument type can't match anyway, so it is safe to discard them. We already do this for simple types, and this PR properly extends it to complex types: Array and Tuple.
Category (leave one):
Short description (up to few sentences):
ClickHouse ignores values on the right side of IN operator that are not convertible to the left side type. Make it work properly for compound types -- Array and Tuple.