support clickhouse as mysql federated server #7717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That's very interesting feature! @yurriy will help with review. |
yurriy
suggested changes
Nov 12, 2019
There was a problem hiding this comment.
Nice feature. Thanks. Could you please add a test?
Tests of MySQL protocol are here. MySQL server will be started in mysql_client docker container if this line is removed. dbms/tests/integration/README.md.
|
Hi, @yurriy. Sorry, was on vacation and only now was able to get back to this commit. I've fixed all issues, that you highlighted and added tests. Thanks, |
yurriy
suggested changes
Nov 27, 2019
dbms/tests/integration/test_mysql_protocol/clients/mysql/docker_compose.yml
Outdated
Show resolved
Hide resolved
yurriy
suggested changes
Nov 28, 2019
|
Hi @yurriy, sorry for stupid mistakes - hadn't written on C++ since university :) I've applied all code review notes, can you please take a look? Thank, |
yurriy
approved these changes
Dec 2, 2019
| if (0 == strncasecmp("SHOW TABLE STATUS LIKE", query.c_str(), 22)) | ||
| { | ||
| should_replace = true; | ||
| replacement_query = boost::replace_all_copy(query, "SHOW TABLE STATUS LIKE ", show_table_status_replacement_query); |
There was a problem hiding this comment.
Here is LIKE. But in replacement query it is just a string equality.
alexey-milovidov
approved these changes
Dec 2, 2019
nikitamikhaylov
added
the
pr-improvement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category (leave one):
Changelog entry (up to few sentences, not needed for non-significant PRs):
Support adding Clickhouse as MySQL federated server (see https://dev.mysql.com/doc/refman/5.7/en/federated-create-server.html)