Fix enum conversion in native format for backward compatibility. #7908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CurtizJ
changed the title
| @@ -92,6 +92,9 @@ ColumnPtr recursiveLowCardinalityConversion(const ColumnPtr & column, const Data | |||
| if (from_type->equals(*to_type)) | |||
| return column; | |||
|
|
|||
| if (WhichDataType(to_type).isEnum() && from_type->getTypeId() == to_type->getTypeId()) | |||
There was a problem hiding this comment.
Also it's not correspond to function name now. Is is used only once. Maybe rename it?
KochetovNicolai
approved these changes
Nov 25, 2019
stavrolia
added
the
pr-bugfix
abyss7
pushed a commit
that referenced
this pull request
Nov 29, 2019
Fix enum conversion in native format for backward compatibility. (cherry picked from commit 4d6214d)
nikitamikhaylov
pushed a commit
that referenced
this pull request
Dec 2, 2019
Fix enum conversion in native format for backward compatibility. (cherry picked from commit 4d6214d)
vitlibar
pushed a commit
that referenced
this pull request
Dec 27, 2019
Fix enum conversion in native format for backward compatibility. (cherry picked from commit 4d6214d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category (leave one):
Changelog entry (up to few sentences, required except for Non-significant/Documentation categories):
Fix enum conversion in native format for backward compatibility.
Detailed description (optional):
Fixes #7836. We can allow insert enum column if it's numeric type is the same as the column's type in table. More details in related issue.