Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed ternary logic (OR/AND/XOR) calculation in multiple batches #8718

Merged

Conversation

Akazz
Copy link
Contributor

@Akazz Akazz commented Jan 18, 2020

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Changelog category (leave one):

  • Bug Fix

Changelog entry (up to few sentences, required except for Non-significant/Documentation categories):
Fixed up a bug in batched calculations of ternary logical OPs on multiple arguments (more than 10).

Detailed description (optional):
Functions or, and might return incorrect results when called on more than 10 arguments while any of them being NULL

Fixes #8469 that was addressed by @YiuRULE in #8511

@Akazz Akazz added the pr-bugfix Pull request with bugfix, not backported by default label Jan 18, 2020
@alexey-milovidov alexey-milovidov merged commit 36a7a40 into ClickHouse:master Jan 19, 2020
alexey-milovidov added a commit that referenced this pull request Jan 19, 2020
A followup to #8718: Simpler and faster code in logical functions
@alesapin alesapin added the v20.1 label Jan 20, 2020
alesapin pushed a commit that referenced this pull request Jan 20, 2020
Fixed ternary logic (OR/AND/XOR) calculation in multiple batches
alesapin pushed a commit that referenced this pull request Jan 20, 2020
A followup to #8718: Simpler and faster code in logical functions
alesapin pushed a commit that referenced this pull request Jan 20, 2020
Fixed ternary logic (OR/AND/XOR) calculation in multiple batches
alesapin pushed a commit that referenced this pull request Jan 20, 2020
A followup to #8718: Simpler and faster code in logical functions
alexey-milovidov added a commit that referenced this pull request Mar 25, 2020
A followup to #8718: Simpler and faster code in logical functions

(cherry picked from commit 9e1ab40)
vitlibar pushed a commit that referenced this pull request Mar 25, 2020
Fixed ternary logic (OR/AND/XOR) calculation in multiple batches

(cherry picked from commit 36a7a40)
vitlibar pushed a commit that referenced this pull request Mar 25, 2020
Fixed ternary logic (OR/AND/XOR) calculation in multiple batches

(cherry picked from commit 36a7a40)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix Pull request with bugfix, not backported by default
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconstitency about the WHERE filtering with Nullable columns with operator <= and >=
3 participants