Reworking fix for issue 7878 #8778
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KochetovNicolai
added
the
pr-bugfix
KochetovNicolai
approved these changes
Jan 22, 2020
added 2 commits
January 22, 2020 22:26
as the other approach caused test regressions. This time we just erase the columns that need to be set to the default value or expression.
|
Changes caused test regressions in 00975_recursive_materialized_view |
|
This solution will not work. Closing this PR and moving work to #8788. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Continuation of #8766.
Fixing issue when a materialized view inner table has different number of columns than the query stored in the materialized view.
Detailed description / Documentation draft:
Reworking fix for issue #7878. Removing NameOrDefault mode from CovertingBlockInputStream and switching to using AddingMissedBlockInputStream to properly support default expressions.