Fix order of ranges in MergeTreeDataSelectExecutor #9050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akuzm
reviewed
Feb 7, 2020
| @@ -251,6 +240,10 @@ void MergeTreeReadPool::fillPerThreadInfo( | |||
| { | |||
| threads_tasks.resize(threads); | |||
|
|
|||
| /// Let the ranges be listed from right to left so that the leftmost range can be dropped using `pop_back()`. | |||
There was a problem hiding this comment.
If the only reason to reverse the array is to have O(1) deletion, we can just use std::deque.
There was a problem hiding this comment.
Yes, we can. Actually I don't know why originally std::vector was used.
Closed
16 tasks
CurtizJ
force-pushed
the
fix-range-reader
branch
from
237c667
to
8527723
Compare
alesapin
approved these changes
Feb 11, 2020
alexey-milovidov
added a commit
that referenced
this pull request
Feb 19, 2020
Fix mistake introduced in #9050.
abyss7
pushed a commit
that referenced
this pull request
Feb 21, 2020
Fix order of ranges in MergeTreeDataSelectExecutor (cherry picked from commit 5b4b04e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix order of ranges while reading from
MergeTreetable in one thread. It could lead to exceptions fromMergeTreeRangeReaderor wrong query results.Fixes #8964.