Send string columns to mysql client as utf8 #9079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Integration test has failed for reason? |
Yes, I noticed the failures, but had no time until today to reproduce and fix them. |
|
It seems that the failures in the last check are not caused by this patch |
Yes, it's unrelated.
Need to dig into it... |
|
Yes, it's known issue that happened to appear on master. |
|
Thank you! |
nikitamikhaylov
added
the
pr-improvement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
After recent changes mysql client started to print binary strings in hex thereby making them not readable (#9032). The workaround in ClickHouse is to mark string columns as utf8, which is not always, but usually the case.