Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add force_optimize_skip_unused_shards_no_nested #9812

Conversation

azat
Copy link
Collaborator

@azat azat commented Mar 22, 2020

Changelog category (leave one):

  • Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Add force_optimize_skip_unused_shards_no_nested that will disable force_optimize_skip_unused_shards for nested Distributed table

Detailed description / Documentation draft:
Can be useful for multi-layred/bi-level sharding.

@azat azat force-pushed the force_optimize_skip_unused_shards-nested branch 2 times, most recently from 79688e4 to eac5f12 Compare March 23, 2020 07:24
@azat azat changed the title Ability to disable force_optimize_skip_unused_shards for nested Distributed Add force_optimize_skip_unused_shards_no_nested Mar 23, 2020
@azat azat force-pushed the force_optimize_skip_unused_shards-nested branch from eac5f12 to 2d828c1 Compare March 23, 2020 08:08
@alexey-milovidov
Copy link
Member

alexey-milovidov commented Mar 23, 2020

Functional stateless tests (debug) — fail: 1, passed: 1658, skipped: 7
Functional stateless tests (ubsan) — Some queries hung, fail: 2, passed: 1660, skipped: 4

- not related.

force_optimize_skip_unused_shards_no_nested will disable
force_optimize_skip_unused_shards for nested Distributed tables.

Can be useful for multi-layred/bi-level sharding.
@azat azat force-pushed the force_optimize_skip_unused_shards-nested branch from 2d828c1 to d019c4e Compare March 23, 2020 19:31
@alexey-milovidov alexey-milovidov merged commit 10b4b05 into ClickHouse:master Mar 24, 2020
@azat azat deleted the force_optimize_skip_unused_shards-nested branch March 24, 2020 06:40
@alesapin alesapin added the pr-improvement Pull request with some product improvements label Mar 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-improvement Pull request with some product improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants