Skip to content

Commit

Permalink
Run tests with Node.js 16/18/20 (#155)
Browse files Browse the repository at this point in the history
  • Loading branch information
slvrtrn authored May 3, 2023
1 parent 7be9673 commit ac72466
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 6 deletions.
8 changes: 4 additions & 4 deletions .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ jobs:
strategy:
fail-fast: true
matrix:
node: [ 14, 16, 18, 19 ]
node: [ 16, 18, 20 ]
steps:
- uses: actions/checkout@main

Expand Down Expand Up @@ -68,7 +68,7 @@ jobs:
strategy:
fail-fast: true
matrix:
node: [ 14, 16, 18, 19 ]
node: [ 16, 18, 20 ]
clickhouse: [ head, latest ]

steps:
Expand Down Expand Up @@ -117,7 +117,7 @@ jobs:
strategy:
fail-fast: true
matrix:
node: [ 14, 16, 18, 19 ]
node: [ 16, 18, 20 ]
clickhouse: [ head, latest ]

steps:
Expand Down Expand Up @@ -150,7 +150,7 @@ jobs:
strategy:
fail-fast: true
matrix:
node: [ 14, 16, 18, 19 ]
node: [ 16, 18, 20 ]

steps:
- uses: actions/checkout@main
Expand Down
2 changes: 1 addition & 1 deletion __tests__/integration/abort_request.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ describe('abort request', () => {
// There was a breaking change in Node.js 18.x+ behavior
if (
process.version.startsWith('v18') ||
process.version.startsWith('v19')
process.version.startsWith('v20')
) {
await expect(selectPromise).rejects.toMatchObject({
message: 'Premature close',
Expand Down
2 changes: 1 addition & 1 deletion __tests__/tls/tls.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ describe('TLS connection', () => {
},
})
const errorMessage =
process.version.startsWith('v18') || process.version.startsWith('v19')
process.version.startsWith('v18') || process.version.startsWith('v20')
? 'unsupported certificate'
: 'socket hang up'
await expect(
Expand Down

0 comments on commit ac72466

Please sign in to comment.