Local ClickHouse cluster configuration #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshustov
reviewed
Aug 10, 2022
docker-compose.cluster.yml
Outdated
| - '9000:9000' | ||
| - '9181:9181' | ||
| volumes: | ||
| - './.docker/clickhouse/cluster/config1.xml:/etc/clickhouse-server/config.xml' |
There was a problem hiding this comment.
Optional: what if we give them more descriptive names? config1.xml --> server_1_config.xml?
|
Going forward I would suggest creating a separate module for reusing that in other drivers/clients (the cluster creation part) |
|
@mzitnik that's a good idea, will do in a new PR |
mshustov
approved these changes
Aug 10, 2022
| query, | ||
| ...this.getBaseParams(params), | ||
| }); | ||
|
|
||
| return new Rows(stream, format); |
There was a problem hiding this comment.
Thinking loudly: we need to rename the result of the operation. not a blocker for the current PR
mshustov
reviewed
Aug 10, 2022
| case 'CLOUD': | ||
| env = TestEnv.Cloud; | ||
| break; | ||
| case 'LOCAL_CLUSTER': |
There was a problem hiding this comment.
Where do we set it? Shouldn't we add a command to package.json to run the tests against a local cluster? Can be done in follow-up, though.
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On top of #22, to keep it cleaner for the review.
Now we can run a ClickHouse cluster locally, with 2 nodes and Clickhouse Keeper (no Zookeeper)
Nginx serves as a load balancer to expose a single ClickHouse endpoint like it is done in the Cloud.