Allow tests to use ClickHouse Cloud, add simple HTTPS support #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slvrtrn
commented
Aug 5, 2022
.github/workflows/run-tests.yml
Outdated
| clickhouse: | ||
| - head | ||
| - latest |
There was a problem hiding this comment.
Need to investigate why we have failures using Cloud env with 4 parallel test runs when using a proper matrix
There was a problem hiding this comment.
Let's create a dedicated issue to fix the problem in a follow-up PR
# Conflicts: # __tests__/unit/parse_error.ts # src/error/parse_error.ts
This was referenced Aug 9, 2022
Closed
* Local ClickHouse cluster configuration * Fix `command` and related tests, use more flexible test env, rename configs
mshustov
approved these changes
Aug 10, 2022
__tests__/utils/client.ts
Outdated
| import { randomUUID } from 'crypto'; | ||
|
|
||
| export type TestClientConfiguration = ClickHouseClientConfigOptions & { | ||
| useCloud?: boolean; |
There was a problem hiding this comment.
Let's add a comment it's a temporary flag until we make all the tests compatible with Cloud.
This was referenced Aug 17, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #6, partially #3