Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/scenario tooltip #117

Merged
merged 4 commits into from
Nov 7, 2018
Merged

Feature/scenario tooltip #117

merged 4 commits into from
Nov 7, 2018

Conversation

weberjavi
Copy link
Contributor

This PR adds a tooltip definition to projected emissions graph.
Pivotal task

To test the implementation head:
http://localhost:3000/ghg-emissions/projected-emissions

kapture 2018-11-06 at 14 15 49

Copy link
Contributor

@simaob simaob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works as expected =)

@Bluesmile82
Copy link
Contributor

There is a problem when deleting an element from the legend. Suddenly all are gone and you can't put them back. Might be a problem with the selected elements filter

@Bluesmile82
Copy link
Contributor

Also, GHG Inventory doesn't have a tooltip but it might be because we don't have data yet. Maybe we should remove it until the data source is clear

Copy link
Contributor

@Bluesmile82 Bluesmile82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check the legend item clear problem

@weberjavi
Copy link
Contributor Author

@Bluesmile82 please check the changes ☝️
About the GHG inventory data not sure what's the best approach. Any thoughts about that @simaob ?

@simaob
Copy link
Contributor

simaob commented Nov 7, 2018

It's because we don't have the data yet. Let's leave it in a way that when the data is populated this will show automatically!

@Bluesmile82
Copy link
Contributor

Working fine now! Thanks! Feel free to merge

@simaob simaob merged commit d1fc216 into develop Nov 7, 2018
@simaob simaob deleted the feature/scenario-tooltip branch November 7, 2018 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants