-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Connects to #846. Connects to #885. #889
Conversation
…earches when no ExAC population data is found in myvariant.info response
… even when there are RefSeq transcripts in the VEP response
…e additional condition for null myvariant.info response
…present in the ClinVar response
@jimmyzhen Typically we have used a dotted line + hover text to show full HGVS names when they are long. Can you comment on why that has not been implemented here for long transcript names? There is currently no way to see the whole term(s). |
Hi @kilodalton, When I worked on #812, I did consider implementing the hover text for long HGVS terms. There were 2 options I was considering:
In option #1, I thought it would be undesirable for the hover text to be displayed for the short HGVS terms and transcripts in the tables. In option #2, I thought it would be inconsistent for one variant to display hover text but not the other as an user may come to expect to see hover text consistently after seeing it in certain variants. Finally, it felt incomplete to display hover text only for the neucleotide change transcripts but not the other data in the tables. And so, in the end, I opted for not displaying the hover text at all. I am open to suggestions. |
…that hide long hgvs term text overflow
Hi Karen, I have committed the changes to this PR for displaying hover text and dotted underline on long HGVS terms whose text overflows. For a comparison to a short HGVS term, you may try 55847 vs 53981 and/or 90973. |
This PR consists of implementations pertinent to the change requests in constructing the external ExAC linkout differently when there is no ExAC population data is found for the table display on the Population tab.
Technical details:
hgvs_notation.js
andparse-resources.js
files, I added "if" statements to several places to ensure script execution even when the expected data is absent in the REST API response.basic_info.js
file, removed no-longer-used code and refactored code to ensure script execution even when the expected data is absent in the REST API response.Steps to test: