Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Fix all dependencies to specific versions #1096

Merged
merged 7 commits into from Feb 27, 2023

Conversation

ivadym
Copy link
Contributor

@ivadym ivadym commented Feb 22, 2023

This PR:

  • Fixed all conda container dependencies
  • Add pip specific missing tools to config

Balsamic container not included as it depends on the release version.

Review and tests:

  • Tests pass

TN-WGS

Screenshot 2023-02-22 at 13 40 55

TN-TGA

Screenshot 2023-02-22 at 13 41 56

PIP specific dependencies (cnvkit) are included now in the config.json file
Screenshot 2023-02-22 at 13 43 30

  • Code review
  • New code is executed and covered by tests, and test approve

@ivadym ivadym linked an issue Feb 22, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Feb 22, 2023

Codecov Report

Base: 99.25% // Head: 99.31% // Increases project coverage by +0.05% 🎉

Coverage data is based on head (c10ca1d) compared to base (5d627dd).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1096      +/-   ##
===========================================
+ Coverage    99.25%   99.31%   +0.05%     
===========================================
  Files           29       29              
  Lines         1755     1756       +1     
===========================================
+ Hits          1742     1744       +2     
+ Misses          13       12       -1     
Flag Coverage Δ
unittests 99.31% <100.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
BALSAMIC/commands/config/case.py 96.96% <ø> (ø)
BALSAMIC/commands/config/pon.py 95.23% <ø> (ø)
BALSAMIC/utils/cli.py 100.00% <100.00%> (+0.30%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ivadym ivadym marked this pull request as ready for review February 22, 2023 09:41
@ivadym ivadym requested a review from a team February 22, 2023 09:41
Copy link
Contributor

@fevac fevac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 🌟 Did you figure out what was the issue before?

BALSAMIC/containers/align_qc/align_qc.yaml Outdated Show resolved Hide resolved
BALSAMIC/containers/align_qc/align_qc.yaml Outdated Show resolved Hide resolved
BALSAMIC/utils/cli.py Show resolved Hide resolved
@ivadym
Copy link
Contributor Author

ivadym commented Feb 22, 2023

Nice! 🌟 Did you figure out what was the issue before?

This part was not flexible enough to allow the new dependency yaml structure:

for p in packages:
if isinstance(p, dict):
continue
name = p.split("::")[1].split("=")[0]
version = "=".join(p.split("=")[1:])

@sonarcloud
Copy link

sonarcloud bot commented Feb 22, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@fevac fevac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@ivadym ivadym merged commit dd864e3 into develop Feb 27, 2023
@ivadym ivadym deleted the fix-container-version branch February 27, 2023 08:57
@ivadym ivadym mentioned this pull request Apr 27, 2023
14 tasks
ivadym added a commit that referenced this pull request May 10, 2023
### Added:
* PIP specific missing tools to config #1096
* Filtering script to remove normal variants from TIDDIT #1120
* Store TMB files in HK #1144

### Changed:
* Fixed all conda container dependencies #1096
* Changed --max_sv_size in VEP params to the size of chr1 for hg19 #1124
* Increased time-limit for sambamba_exon_depth and picard_markduplicates to 6 hours #1143
* Update cosmicdb to v97 #1147
* Updated read the docs with the changes relevant to mention #1153

### Fixed:
* Update cryptography version (39.0.1) due to security alert #1087
* Bump cryptography to v40.0.2 and gsutil to v5.23 #1154
* Pytest file saved in balsamic directory #1093
* Fix varcall_py3 container bcftools dependency error #1097
* AscatNgs container #1155
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Explicitly specify versions for all dependencies for containers
5 participants