Feature/test function hash #875

henrikstranneheim · 2019-06-19T19:15:43Z

This PR fixes:

Extend the test_function to handle hashes? #520

How to test:

Automatic and continuous test pass

Expected outcome:

Installation, unit and integration tests pass

Review:

Code review
New code is executed and covered by tests
Tests pass

#520 - Added test for build_call - Extended test for test_function - Command modules that need to supply a hash function need to sort the keys alphabetically to enable predicitive testing. Example is in test_function test_command sub

#520

jemten · 2019-06-20T08:48:40Z

lib/MIP/Test/Commands.pm

 use MIP::Test::Writefile qw{ test_write_to_file };

 ## Constants
 Readonly my $ERROR_MSG_INDENT => 3;
-Readonly my $SPACE => q{ };
+Readonly my $SPACE            => q{ };


Import $SPACE from Constants

jemten

Looks good! This adds some nice flexibility as to how arguments can be submitted and tested for command modules :)
Like the star wars theme 👾

henrikstranneheim added 2 commits June 19, 2019 15:57

feat(test_function): Added example in command_module for hash input. Fix

67c878b

#520

henrikstranneheim requested a review from jemten as a code owner June 19, 2019 19:15

jemten reviewed Jun 20, 2019

View reviewed changes

jemten approved these changes Jun 20, 2019

View reviewed changes

feat(test_function): Added import of constant

5ccac09

henrikstranneheim merged commit 50d54ff into develop Jun 20, 2019

henrikstranneheim deleted the feature/test_function_hash branch June 20, 2019 14:52

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature/test function hash #875

Feature/test function hash #875

henrikstranneheim commented Jun 19, 2019 •

edited

Loading

jemten Jun 20, 2019

jemten left a comment

Feature/test function hash #875

Feature/test function hash #875

Conversation

henrikstranneheim commented Jun 19, 2019 • edited Loading

This PR fixes:

How to test:

Expected outcome:

Review:

jemten Jun 20, 2019

Choose a reason for hiding this comment

jemten left a comment

Choose a reason for hiding this comment

henrikstranneheim commented Jun 19, 2019 •

edited

Loading