Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend the test_function to handle hashes? #520

Closed
jemten opened this issue Jun 18, 2018 · 1 comment
Closed

Extend the test_function to handle hashes? #520

jemten opened this issue Jun 18, 2018 · 1 comment
Assignees
@henrikstranneheim
Labels
Enhancement Question
Milestone
MIP 7.1

Comments

@jemten
Copy link
Collaborator

jemten commented Jun 18, 2018

Sometimes it is necessary to pass hashes to a command module. Currently the test_function that we use to test the command modules does not handle hashes.
@henrikstranneheim henrikstranneheim added this to the MIP 8.0 milestone Jan 24, 2019
@henrikstranneheim henrikstranneheim self-assigned this Jun 19, 2019
henrikstranneheim added a commit that referenced this issue Jun 19, 2019
@henrikstranneheim
feat(test_funtion): Extended test_function to handle hashes as well. Fix
e801e38 
 #520

- Added test for build_call
- Extended test for test_function
- Command modules that need to supply a hash function need to sort the keys alphabetically to enable predicitive testing. Example is in test_function test_command sub
henrikstranneheim added a commit that referenced this issue Jun 19, 2019
@henrikstranneheim
feat(test_function): Added example in command_module for hash input. Fix
67c878b 
 #520
@henrikstranneheim henrikstranneheim mentioned this issue Jun 19, 2019
Merged
3 tasks
@henrikstranneheim
Copy link
Collaborator

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@henrikstranneheim henrikstranneheim

Labels
Enhancement Question
Projects
None yet
Milestone
MIP 7.1
Development

No branches or pull requests
2 participants
@henrikstranneheim @jemten