Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/add to consequence hash #898

Merged
merged 3 commits into from
Aug 12, 2019

Conversation

henrikstranneheim
Copy link
Collaborator

@henrikstranneheim henrikstranneheim commented Aug 12, 2019

This PR fixes:

  • First part of refactoring parse_csq

How to test:

  • Automatic and continuous test pass

Expected outcome:

  • Installation, unit and integration tests pass

Review:

  • Code review
  • New code is executed and covered by tests
  • Tests pass

- Added initiation of arbirtrary high consequence score to avoid having to check for
  existence for each consequence term
Copy link
Collaborator

@jemten jemten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The indentation looks a bit strange

vcfparser.pl Outdated
@@ -879,6 +881,10 @@ sub parse_vep_csq {
\$transcript_effects[ $vep_format_field_column_href->{Allele} ]
; #Alias allele

if (not exists $consequence_href->{$$hgnc_id_ref}{$$allele_ref}{rank} ) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indentation

vcfparser.pl Outdated
\$consequence_severity_href->{$consequence_term}
{rank},
}
## Map of what to set to consequence
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indentation

@henrikstranneheim henrikstranneheim merged commit 31afb20 into develop Aug 12, 2019
@henrikstranneheim henrikstranneheim deleted the feature/add_to_consequence_hash branch August 12, 2019 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants