Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new qPCR EPP #478

Merged
merged 11 commits into from Apr 16, 2024
Merged

Add new qPCR EPP #478

merged 11 commits into from Apr 16, 2024

Conversation

Karl-Svard
Copy link
Collaborator

Added

  • new EPP cg_lims/EPPs/udf/calculate/qpcr_dilution.py
  • new constant WELL_TRANSFORMER in cg_lims/EPPs/udf/calculate/constants.py
  • new required package openpyxl
  • new options for click

Steps to consider while deploying

  • Configuration changes:
  • Documentation updates:
  • Inform users by email:

Review:

  • Code approved by
  • Tests executed on stage by: (Document the test done with screen shots and description.)
  • "Merge and deploy" approved by

This version is a:

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

This was referenced Mar 15, 2024
@Karl-Svard
Copy link
Collaborator Author

Tests performed on stage confirmed the values matched those done with calculation sheets, e.g. https://docs.google.com/spreadsheets/d/1fZ5lBk0N_L4q5LwSb6E_EvKbdmsH7Qr8EASjc5J2w2o/edit#gid=0

Changing the replicate and conc. threshold affected the results as expected.

Copy link
Contributor

@idalindegaard idalindegaard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ser bra ut! Vilket jobb 🔥💯👏

@Karl-Svard Karl-Svard merged commit 8b74e9f into master Apr 16, 2024
2 checks passed
@Karl-Svard Karl-Svard deleted the qpcr_vol2 branch April 16, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants