Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update concentration input of Saphyr Average concentration and CV calculation script #491

Merged
merged 1 commit into from Mar 28, 2024

Conversation

idalindegaard
Copy link
Contributor

Added

Changed

  • Made the number of concentration replicates flexible
  • Added a new click option

Fixed

Steps to consider while deploying

  • Configuration changes:
  • Documentation updates:
  • Inform users by email:

Review:

  • Code approved by
  • Tests executed on stage by: (Document the test done with screen shots and description.)
  • "Merge and deploy" approved by

This version is a:

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

@idalindegaard
Copy link
Contributor Author

Quick test in the Post-prepp QC Saphyr step where we have only two concentration values (instead of three as in the initial QC step) to consider for the average concentration and CV value:

A "successful" input:
Screenshot 2024-03-28 at 13 41 33
Screenshot 2024-03-28 at 13 42 26

An "unsuccessful" input with a negative value:
Screenshot 2024-03-28 at 13 43 06
Screenshot 2024-03-28 at 13 43 40

Conclusion: The script works for a varying number of input concentrations

Copy link
Collaborator

@Karl-Svard Karl-Svard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥🔥🔥

@Karl-Svard Karl-Svard merged commit 5bda02d into master Mar 28, 2024
2 checks passed
@Karl-Svard Karl-Svard deleted the saphyr_concentration_update branch March 28, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants