Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite CLI #71

Merged
merged 96 commits into from
Sep 15, 2020
Merged

Rewrite CLI #71

merged 96 commits into from
Sep 15, 2020

Conversation

moonso
Copy link
Contributor

@moonso moonso commented Aug 20, 2020

Summary

This pull request reworks the CLI completely. The idea is to make it more clear how bundles, versions and files are linked together. Each subcommand will follow the same structure so there will for example housekeeper get

housekeeper get --help
Usage: housekeeper get [OPTIONS] COMMAND [ARGS]...

  Get info from database

Options:
  --help  Show this message and exit.

Commands:
  bundles  Get bundle from database
  files    Get files from database
  tags     Get the tags from database
  version  Get versions from database

and add:

housekeeper add --help
Usage: housekeeper add [OPTIONS] COMMAND [ARGS]...

  Add things to the store.

Options:
  --help  Show this message and exit.

Commands:
  bundle   Add a new bundle.
  file     Add a file to the latest version of a bundle.
  tag      Add tags to housekeeper.
  version  Add a new version to a bundle.

Testing

How to prepare for test

  • ssh to hasta
  • install on stage:
    bash /home/proj/production/servers/resources/hasta.scilifelab.se/update-housekeeper-stage.sh log-output
  • Check that there is a mip cases to store (vitalmouse)

How to test

  • Store a case in housekeeper (this is to check that the interaction between CG and hk works as expected)

Expected test outcome

  • check that the test succeded
  • Take a screenshot and attach or copy/paste the output.

Skärmavbild 2020-09-14 kl  13 21 56

Review

  • code approved by @Mropat
  • tests executed by @moonso
  • "Merge and deploy" approved by @moonso
    Thanks for filling in who performed the code review and the test!

This version is a:

  • MAJOR - when you make incompatible API changes

@patrikgrenfeldt
Copy link
Contributor

Suggestion, please change "cannot delete X, X contains Y" to "Cannot delete X, please remove all Ys first" to let the user know what actions are needed

@moonso moonso merged commit e9b87c4 into master Sep 15, 2020
@moonso moonso deleted the log-output branch September 15, 2020 07:22
@moonso
Copy link
Contributor Author

moonso commented Sep 15, 2020

Skärmavbild 2020-09-15 kl  09 35 10

Merged and deployed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants