Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cancel tower analysis #286

Merged
merged 20 commits into from
Oct 9, 2023
Merged

Cancel tower analysis #286

merged 20 commits into from
Oct 9, 2023

Conversation

fevac
Copy link
Contributor

@fevac fevac commented Sep 22, 2023

Description

Closes: #226

Changed

  • cancel supports NF-Tower cases

How to prepare for test

  • ssh to hasta (depending on type of change)
  • activate stage: us
  • request trailblazer-stage on hasta: paxa
  • install on stage:
    bash /home/proj/production/servers/resources/hasta.scilifelab.se/update-tool-stage.sh -e S_trailblazer -t trailblazer -b  cancel_tower -a

How to test

  • Cancel not ongoing analysis: trailblazer cancel 279435. It should raise the following error: TrailblazerError: Analysis 279435 is not running
  • Cancel ongoing analysis with failed tower response: trailblazer cancel 279435. It should raise the following error: Request failed for url {url}: Error: {error}
  • Cancel ongoing analysis: trailblazer cancel 271983. It complete successfully with the following message: Analysis 279435: cancelled successfully!

Review

  • tests executed by EFC
  • "Merge and deploy" approved by
    Thanks for filling in who performed the code review and the test!

This version is a

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

@fevac fevac mentioned this pull request Sep 22, 2023
14 tasks
@fevac fevac marked this pull request as ready for review September 22, 2023 07:55
@fevac fevac requested a review from a team as a code owner September 22, 2023 07:55
Copy link
Contributor

@henrikstranneheim henrikstranneheim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

tests/store/crud/test_update.py Outdated Show resolved Hide resolved
tests/store/crud/test_update.py Outdated Show resolved Hide resolved
trailblazer/store/crud/update.py Outdated Show resolved Hide resolved
trailblazer/store/crud/update.py Outdated Show resolved Hide resolved
Copy link
Contributor

@seallard seallard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍 Was a little confused by some stuff, nothing about the logic though

@clingen-sthlm clingen-sthlm temporarily deployed to stage October 9, 2023 07:36 Inactive
@clingen-sthlm clingen-sthlm temporarily deployed to stage October 9, 2023 07:43 Inactive
@clingen-sthlm clingen-sthlm temporarily deployed to stage October 9, 2023 07:51 Inactive
@clingen-sthlm clingen-sthlm temporarily deployed to stage October 9, 2023 08:23 Inactive
@clingen-sthlm clingen-sthlm temporarily deployed to stage October 9, 2023 08:28 Inactive
@clingen-sthlm clingen-sthlm temporarily deployed to stage October 9, 2023 08:42 Inactive
@clingen-sthlm clingen-sthlm temporarily deployed to stage October 9, 2023 08:52 Inactive
@clingen-sthlm clingen-sthlm temporarily deployed to stage October 9, 2023 09:03 Inactive
@clingen-sthlm clingen-sthlm temporarily deployed to stage October 9, 2023 09:48 Inactive
@fevac
Copy link
Contributor Author

fevac commented Oct 9, 2023

tests passing

@sonarcloud
Copy link

sonarcloud bot commented Oct 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@clingen-sthlm clingen-sthlm temporarily deployed to stage October 9, 2023 10:00 Inactive
@fevac fevac merged commit 8ae79da into master Oct 9, 2023
6 checks passed
@fevac fevac deleted the cancel_tower branch October 9, 2023 10:02
@fevac
Copy link
Contributor Author

fevac commented Oct 9, 2023

  • Deployed to stage
image
  • Deployed to production
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cancel Tower analysis
4 participants