Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cancel tower workflow #242

Closed
wants to merge 8 commits into from
Closed

Cancel tower workflow #242

wants to merge 8 commits into from

Conversation

fevac
Copy link
Contributor

@fevac fevac commented Jul 27, 2023

Description

Closes: #226

Changed

  • cancel supports NF-Tower cases

How to prepare for test

  • ssh to hasta (depending on type of change)
  • activate stage: us
  • request trailblazer-stage on hasta: paxa
  • install on stage:
    bash /home/proj/production/servers/resources/hasta.scilifelab.se/update-tool-stage.sh -e S_trailblazer -t trailblazer -b  cancel_tower_workflow -a

How to test

  • Cancel not ongoing analysis: trailblazer cancel 271983. It should raise the following error: TrailblazerError: Analysis 271983 is not running
  • Cancel ongoing analysis with failed tower response: trailblazer cancel 271983. It should raise the following error: Request failed for url {url}: Error: {error}
  • Cancel ongoing analysis: trailblazer cancel 271983. It complete successfully with the following message: Analysis 271983: all ongoing jobs cancelled successfully!

Expected test outcome

  • check that ...
  • Take a screenshot and attach or copy/paste the output.

Review

  • tests executed by
  • "Merge and deploy" approved by
    Thanks for filling in who performed the code review and the test!

This version is a

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

@clingen-sthlm clingen-sthlm temporarily deployed to stage July 27, 2023 12:21 Inactive
@clingen-sthlm clingen-sthlm temporarily deployed to stage July 27, 2023 13:37 Inactive
@clingen-sthlm clingen-sthlm temporarily deployed to stage July 27, 2023 13:55 Inactive
@fevac
Copy link
Contributor Author

fevac commented Jul 27, 2023

need to update canceled/cancelled status prior this PR. Opening a different PR for it

@sonarcloud
Copy link

sonarcloud bot commented Jul 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarcloud
Copy link

sonarcloud bot commented Sep 22, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@fevac
Copy link
Contributor Author

fevac commented Sep 22, 2023

Closing in favour of #286. Was easier to start again than update all changes in master

@fevac fevac closed this Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cancel Tower analysis
2 participants