Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Docker Image #29

Merged
merged 3 commits into from
May 27, 2023
Merged

Add Docker Image #29

merged 3 commits into from
May 27, 2023

Conversation

mkuf
Copy link
Contributor

@mkuf mkuf commented May 26, 2023

Hi,

I'd like to run the mobileraker_companion in Docker to be able to add it to my project: https://github.com/mkuf/prind

This PR adds:

  • A Dockerfile at the Root of the repository, along with a dockerignore file
  • A github workflow that builds the docker image and uploads it to ghcr.io
  • A few lines of documentation about the image in the main Readme

Commits to the main Branch will build the latest tag for the Image.
Tagged commits will result in an image tag equal to the git tag.

For the Workflow to function, you'll have to enable Read and Write Permissions at Settings/Actions/General/Workflow Permissions, otherwise the Image upload to ghcr will fail.

Looking forward to your response.
-Markus

@Clon1998
Copy link
Owner

Hey,
thanks for your contribution! I will look into that hopefully later today or tomorrow. In case I forget about it, just ping me again.

Also your PrintD project looks really interesting and I am proud you want to include mobileraker to it.

@Clon1998 Clon1998 merged commit 140cec9 into Clon1998:main May 27, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants