-
-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version 2.0.0 beta 1 - Back Button not working, Popups not closing #448
Comments
shpongledsummer
added
bug
Something isn't working
bug?
Something may not working?
labels
Apr 14, 2024
Same here, same issue.. |
I will take a look at this, thank you for the feedback! |
Clooos
added a commit
that referenced
this issue
Apr 16, 2024
- [ ] README update for v2 - [ ] Scroll to close not working anymore - [ ] Fix reload when in editor - [ ] Possibility to disable the text autoscroll - [ ] Constant speed for the text autoscroll? - [ ] The horizontal buttons start in the middle to the right and can‘t be moved, like you can on a mobile (using the vertical layout-card) - [ ] For media player volume, showing the percentage on the slider - [ ] For media player volume, "input" it on release rather than as a continuous level. - [ ] With button_type slider the icon always shows a closed cover. - [ ] I have the template Helper which counts lights open separately, and I can see it updates without any problems. But not in the bubble card? - [ ] Info text in switch editor with covers and input_number - [x] Glitch slider old iPad (seems fixed) - [x] Fix when the sidebar is hidden broken #453 - [x] If a pop-up has no header I will render it fully, or partially - [x] Pop-up bg background can't be a variable of a theme - [x] Sub-buttons issue (unable to reproduce but fixed an issue with the delete button): https://www.reddit.com/r/homeassistant/comments/1c39b1t/comment/kzoffff/?utm_source=share&utm_medium=web3x&utm_name=web3xcss&utm_term=1&utm_content=share_button - [x] t would be nice to have an option to always open the pop-up at the top. If I open a pop-up and scroll down, then close it and then reopen it, the pop-up is still at the bottom position. - [x] Performance improvement: add transition-delay to backdrop #456 - [x] Back Button not working, Popups not closing #448 - [x] HBS state error #450 - [x] HBS padding error #452 - [x] Issue on mobile when I have a Thermostat card in the Vertical Stack - it looks like my Thermostat card is messing with the width of the popup, causing all of my buttons to bleed off the side of the screen. (Unable to replicate, is this issue was only happening on previous versions?)
Clooos
added a commit
that referenced
this issue
Apr 16, 2024
- [ ] README update for v2 - [ ] Fix reload when in editor - [ ] Possibility to disable the text autoscroll - [ ] Constant speed for the text autoscroll? - [ ] The horizontal buttons start in the middle to the right and can‘t be moved, like you can on a mobile (using the vertical layout-card) - [ ] For media player volume, showing the percentage on the slider - [ ] For media player volume, "input" it on release rather than as a continuous level. - [ ] With button_type slider the icon always shows a closed cover. - [ ] I have the template Helper which counts lights open separately, and I can see it updates without any problems. But not in the bubble card? - [ ] Info text in switch editor with covers and input_number - [x] Scroll to close not working anymore (added a new slide effect starting from the header) - [x] Glitch slider old iPad (seems fixed) - [x] Fix when the sidebar is hidden broken #453 - [x] If a pop-up has no header I will render it fully, or partially - [x] Pop-up bg background can't be a variable of a theme - [x] Sub-buttons issue (unable to reproduce but fixed an issue with the delete button): https://www.reddit.com/r/homeassistant/comments/1c39b1t/comment/kzoffff/?utm_source=share&utm_medium=web3x&utm_name=web3xcss&utm_term=1&utm_content=share_button - [x] t would be nice to have an option to always open the pop-up at the top. If I open a pop-up and scroll down, then close it and then reopen it, the pop-up is still at the bottom position. - [x] Performance improvement: add transition-delay to backdrop #456 - [x] Back Button not working, Popups not closing #448 - [x] HBS state error #450 - [x] HBS padding error #452 - [x] Issue on mobile when I have a Thermostat card in the Vertical Stack - it looks like my Thermostat card is messing with the width of the popup, causing all of my buttons to bleed off the side of the screen. (Unable to replicate, is this issue was only happening on previous versions?)
Clooos
added a commit
that referenced
this issue
Apr 16, 2024
- [ ] README update for v2 - [ ] Fix reload when in editor - [ ] Possibility to disable the text autoscroll - [ ] Constant speed for the text autoscroll? - [ ] The horizontal buttons start in the middle to the right and can‘t be moved, like you can on a mobile (using the vertical layout-card) - [ ] For media player volume, showing the percentage on the slider - [ ] For media player volume, "input" it on release rather than as a continuous level. - [ ] With button_type slider the icon always shows a closed cover. - [ ] I have the template Helper which counts lights open separately, and I can see it updates without any problems. But not in the bubble card? - [x] Info text in button editor with covers and input_number - [x] Viewport moves to top before opening popup #458 - [x] Added a visual feedback on sub-buttons - [x] The feedback on buttons is not triggered when taping a sub-button - [x] Scroll to close not working anymore (added a new slide effect starting from the header) - [x] Glitch slider old iPad (seems fixed) - [x] Fix when the sidebar is hidden broken #453 - [x] If a pop-up has no header I will render it fully, or partially - [x] Pop-up bg background can't be a variable of a theme - [x] Sub-buttons issue (unable to reproduce but fixed an issue with the delete button): https://www.reddit.com/r/homeassistant/comments/1c39b1t/comment/kzoffff/?utm_source=share&utm_medium=web3x&utm_name=web3xcss&utm_term=1&utm_content=share_button - [x] t would be nice to have an option to always open the pop-up at the top. If I open a pop-up and scroll down, then close it and then reopen it, the pop-up is still at the bottom position. - [x] Performance improvement: add transition-delay to backdrop #456 - [x] Back Button not working, Popups not closing #448 - [x] HBS state error #450 - [x] HBS padding error #452 - [x] Issue on mobile when I have a Thermostat card in the Vertical Stack - it looks like my Thermostat card is messing with the width of the popup, causing all of my buttons to bleed off the side of the screen. (Unable to replicate, is this issue was only happening on previous versions?)
I've released a new beta that fix that issue! Here is the changelog: https://github.com/Clooos/Bubble-Card/releases/tag/v2.0.0-beta.2 |
Clooos
added a commit
that referenced
this issue
Apr 23, 2024
- [ ] README update for v2 - [ ] Fix reload when in editor - [ ] Possibility to disable the text autoscroll - [ ] Constant speed for the text autoscroll? - [ ] The horizontal buttons start in the middle to the right and can‘t be moved, like you can on a mobile (using the vertical layout-card) - [ ] For media player volume, showing the percentage on the slider - [ ] For media player volume, "input" it on release rather than as a continuous level. - [ ] With button_type slider the icon always shows a closed cover. https://github.com/custom-cards/custom-card-helpers/blob/master/src/cover_icon.ts - [ ] I have the template Helper which counts lights open separately, and I can see it updates without any problems. But not in the bubble card? - [ ] Additional info. I have enabled the fix when sidebar is hidden. As soon as I disable it all horizontal buttons disappear… - [ ] HBS padding fix issue? (Waiting for feedback) - [ ] Re-adding the previous scroll to close for the pop-ups - [ ] relative_time.ts:19 Uncaught RangeError: Value need to be finite number for Intl.RelativeTimeFormat.prototype.format() at RelativeTimeFormat.format (<anonymous>) - [x] Editor issue for sub-buttons in some cases - [x] Tap_action fix - [x] Pop-up layout fixed - [x] Info text in switch editor with covers and input_number - [x] Viewport moves to top before opening popup #458 - [x] Added a visual feedback on sub-buttons - [x] The feedback on buttons is not triggered when taping a sub-button - [x] Scroll to close not working anymore (added a new slide effect starting from the header) - [x] Glitch slider old iPad (seems fixed) - [x] Fix when the sidebar is hidden broken #453 - [x] If a pop-up has no header I will render it fully, or partially - [x] Pop-up bg background can't be a variable of a theme - [x] Sub-buttons issue (unable to reproduce but fixed an issue with the delete button): https://www.reddit.com/r/homeassistant/comments/1c39b1t/comment/kzoffff/?utm_source=share&utm_medium=web3x&utm_name=web3xcss&utm_term=1&utm_content=share_button - [x] t would be nice to have an option to always open the pop-up at the top. If I open a pop-up and scroll down, then close it and then reopen it, the pop-up is still at the bottom position. - [x] Performance improvement: add transition-delay to backdrop #456 - [x] Back Button not working, Popups not closing #448 - [x] HBS state error #450 - [x] HBS padding error #452 - [x] Issue on mobile when I have a Thermostat card in the Vertical Stack - it looks like my Thermostat card is messing with the width of the popup, causing all of my buttons to bleed off the side of the screen. (Unable to replicate, is this issue was only happening on previous versions?)
Clooos
added a commit
that referenced
this issue
Apr 25, 2024
- [ ] README update for v2 - [x] For media player volume, showing the percentage on the slider - [x] Possibility to disable the text autoscroll - [x] Sub-buttons dom changing every hass updates? - [x] Default actions sub-buttons - [x] Chromecast fix (working?) - [x] Re-adding the previous scroll to close for the pop-ups - [x] The horizontal buttons start in the middle to the right and can‘t be moved, like you can on a mobile (using the vertical layout-card) - [x] relative_time.ts:19 Uncaught RangeError: Value need to be finite number for Intl.RelativeTimeFormat.prototype.format() at RelativeTimeFormat.format (<anonymous>) - [x] I have the template Helper which counts lights open separately, and I can see it updates without any problems. But not in the bubble card? - [x] Slider that keeps scrolling on desktop - [x] HBS padding fix issue? (Waiting for feedback) - [x] Additional info. I have enabled the fix when sidebar is hidden. As soon as I disable it all horizontal buttons disappear… (Fixed and there is no need to add the fix anymore, on pop-ups too) - [x] Default icons for (almost?) everything - [x] With button_type slider the icon always shows a closed cover. - [x] Editor issue for sub-buttons in some cases - [x] Tap_action fix - [x] Pop-up layout fixed - [x] Info text in switch editor with covers and input_number - [x] Viewport moves to top before opening popup #458 - [x] Added a visual feedback on sub-buttons - [x] The feedback on buttons is not triggered when taping a sub-button - [x] Scroll to close not working anymore (added a new slide effect starting from the header) - [x] Glitch slider old iPad (seems fixed) - [x] Fix when the sidebar is hidden broken #453 - [x] If a pop-up has no header I will render it fully, or partially - [x] Pop-up bg background can't be a variable of a theme - [x] Sub-buttons issue (unable to reproduce but fixed an issue with the delete button): https://www.reddit.com/r/homeassistant/comments/1c39b1t/comment/kzoffff/?utm_source=share&utm_medium=web3x&utm_name=web3xcss&utm_term=1&utm_content=share_button - [x] t would be nice to have an option to always open the pop-up at the top. If I open a pop-up and scroll down, then close it and then reopen it, the pop-up is still at the bottom position. - [x] Performance improvement: add transition-delay to backdrop #456 - [x] Back Button not working, Popups not closing #448 - [x] HBS state error #450 - [x] HBS padding error #452 - [x] Issue on mobile when I have a Thermostat card in the Vertical Stack - it looks like my Thermostat card is messing with the width of the popup, causing all of my buttons to bleed off the side of the screen. (Unable to replicate, is this issue was only happening on previous versions?)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
First of all, thanks for this great card and especially all the new features!
I upgraded to the V2 beta 1 version today and noticed closing the popup by navigating back with the 'back button' is not working properly anymore.
The popup itself closes after a short delay, but the background overlay remains visible. I tried deactivating the background overlay, which didn't help. I'm using the android companion app, but this also happens if I open HA in chrome.
The text was updated successfully, but these errors were encountered: