Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance improvement: add transition-delay to backdrop #456

Closed
hellomarb opened this issue Apr 15, 2024 · 2 comments
Closed

Performance improvement: add transition-delay to backdrop #456

hellomarb opened this issue Apr 15, 2024 · 2 comments

Comments

@hellomarb
Copy link

hellomarb commented Apr 15, 2024

I experienced some browser rendering hiccups with the current backdrop transition which is a combination out of a transformed popup and the backdrop and opacity transition in the background.

An improvement would be adding a transition-delay to .bubble-backdrop in the popup/styles.ts:

transition-delay: 0.1s;

So the browser don't have to blur the whole viewport and animate the transition, the animations are run much smoother on my iPhone to M1 and M2 Pro Macs in latest Chrome engines.

@Clooos
Copy link
Owner

Clooos commented Apr 16, 2024

Good to know! I will change that in the next beta. Thank you!

Clooos added a commit that referenced this issue Apr 16, 2024
- [ ] README update for v2
- [ ] Scroll to close not working anymore
- [ ] Fix reload when in editor
- [ ] Possibility to disable the text autoscroll
- [ ] Constant speed for the text autoscroll?
- [ ] The horizontal buttons start in the middle to the right and can‘t be moved, like you can on a mobile (using the vertical layout-card)
- [ ] For media player volume, showing the percentage on the slider
- [ ] For media player volume, "input" it on release rather than as a continuous level.
- [ ] With button_type slider the icon always shows a closed cover.
- [ ] I have the template Helper which counts lights open separately, and I can see it updates without any problems. But not in the bubble card?
- [ ] Info text in switch editor with covers and input_number
- [x] Glitch slider old iPad (seems fixed)
- [x] Fix when the sidebar is hidden broken #453
- [x] If a pop-up has no header I will render it fully, or partially
- [x] Pop-up bg background can't be a variable of a theme
- [x] Sub-buttons issue (unable to reproduce but fixed an issue with the delete button): https://www.reddit.com/r/homeassistant/comments/1c39b1t/comment/kzoffff/?utm_source=share&utm_medium=web3x&utm_name=web3xcss&utm_term=1&utm_content=share_button
- [x] t would be nice to have an option to always open the pop-up at the top. If I open a pop-up and scroll down, then close it and then reopen it, the pop-up is still at the bottom position.
- [x] Performance improvement: add transition-delay to backdrop #456
- [x] Back Button not working, Popups not closing #448
- [x] HBS state error #450
- [x] HBS padding error #452
- [x] Issue on mobile when I have a Thermostat card in the Vertical Stack - it looks like my Thermostat card is messing with the width of the popup, causing all of my buttons to bleed off the side of the screen. (Unable to replicate, is this issue was only happening on previous versions?)
Clooos added a commit that referenced this issue Apr 16, 2024
- [ ] README update for v2
- [ ] Fix reload when in editor
- [ ] Possibility to disable the text autoscroll
- [ ] Constant speed for the text autoscroll?
- [ ] The horizontal buttons start in the middle to the right and can‘t be moved, like you can on a mobile (using the vertical layout-card)
- [ ] For media player volume, showing the percentage on the slider
- [ ] For media player volume, "input" it on release rather than as a continuous level.
- [ ] With button_type slider the icon always shows a closed cover.
- [ ] I have the template Helper which counts lights open separately, and I can see it updates without any problems. But not in the bubble card?
- [ ] Info text in switch editor with covers and input_number
- [x] Scroll to close not working anymore (added a new slide effect starting from the header)
- [x] Glitch slider old iPad (seems fixed)
- [x] Fix when the sidebar is hidden broken #453
- [x] If a pop-up has no header I will render it fully, or partially
- [x] Pop-up bg background can't be a variable of a theme
- [x] Sub-buttons issue (unable to reproduce but fixed an issue with the delete button): https://www.reddit.com/r/homeassistant/comments/1c39b1t/comment/kzoffff/?utm_source=share&utm_medium=web3x&utm_name=web3xcss&utm_term=1&utm_content=share_button
- [x] t would be nice to have an option to always open the pop-up at the top. If I open a pop-up and scroll down, then close it and then reopen it, the pop-up is still at the bottom position.
- [x] Performance improvement: add transition-delay to backdrop #456
- [x] Back Button not working, Popups not closing #448
- [x] HBS state error #450
- [x] HBS padding error #452
- [x] Issue on mobile when I have a Thermostat card in the Vertical Stack - it looks like my Thermostat card is messing with the width of the popup, causing all of my buttons to bleed off the side of the screen. (Unable to replicate, is this issue was only happening on previous versions?)
Clooos added a commit that referenced this issue Apr 16, 2024
- [ ] README update for v2
- [ ] Fix reload when in editor
- [ ] Possibility to disable the text autoscroll
- [ ] Constant speed for the text autoscroll?
- [ ] The horizontal buttons start in the middle to the right and can‘t be moved, like you can on a mobile (using the vertical layout-card)
- [ ] For media player volume, showing the percentage on the slider
- [ ] For media player volume, "input" it on release rather than as a continuous level.
- [ ] With button_type slider the icon always shows a closed cover.
- [ ] I have the template Helper which counts lights open separately, and I can see it updates without any problems. But not in the bubble card?
- [x] Info text in button editor with covers and input_number
- [x] Viewport moves to top before opening popup #458
- [x] Added a visual feedback on sub-buttons
- [x] The feedback on buttons is not triggered when taping a sub-button
- [x] Scroll to close not working anymore (added a new slide effect starting from the header)
- [x] Glitch slider old iPad (seems fixed)
- [x] Fix when the sidebar is hidden broken #453
- [x] If a pop-up has no header I will render it fully, or partially
- [x] Pop-up bg background can't be a variable of a theme
- [x] Sub-buttons issue (unable to reproduce but fixed an issue with the delete button): https://www.reddit.com/r/homeassistant/comments/1c39b1t/comment/kzoffff/?utm_source=share&utm_medium=web3x&utm_name=web3xcss&utm_term=1&utm_content=share_button
- [x] t would be nice to have an option to always open the pop-up at the top. If I open a pop-up and scroll down, then close it and then reopen it, the pop-up is still at the bottom position.
- [x] Performance improvement: add transition-delay to backdrop #456
- [x] Back Button not working, Popups not closing #448
- [x] HBS state error #450
- [x] HBS padding error #452
- [x] Issue on mobile when I have a Thermostat card in the Vertical Stack - it looks like my Thermostat card is messing with the width of the popup, causing all of my buttons to bleed off the side of the screen. (Unable to replicate, is this issue was only happening on previous versions?)
@Clooos
Copy link
Owner

Clooos commented Apr 16, 2024

I've released a new beta with your fix! Thanks again!

https://github.com/Clooos/Bubble-Card/releases/tag/v2.0.0-beta.2

@Clooos Clooos closed this as completed Apr 16, 2024
Clooos added a commit that referenced this issue Apr 23, 2024
- [ ] README update for v2
- [ ] Fix reload when in editor
- [ ] Possibility to disable the text autoscroll
- [ ] Constant speed for the text autoscroll?
- [ ] The horizontal buttons start in the middle to the right and can‘t be moved, like you can on a mobile (using the vertical layout-card)
- [ ] For media player volume, showing the percentage on the slider
- [ ] For media player volume, "input" it on release rather than as a continuous level.
- [ ] With button_type slider the icon always shows a closed cover. https://github.com/custom-cards/custom-card-helpers/blob/master/src/cover_icon.ts
- [ ] I have the template Helper which counts lights open separately, and I can see it updates without any problems. But not in the bubble card?
- [ ] Additional info. I have enabled the fix when sidebar is hidden. As soon as I disable it all horizontal buttons disappear…
- [ ] HBS padding fix issue? (Waiting for feedback)
- [ ] Re-adding the previous scroll to close for the pop-ups
- [ ] relative_time.ts:19 Uncaught RangeError: Value need to be finite number for Intl.RelativeTimeFormat.prototype.format() at RelativeTimeFormat.format (<anonymous>)
- [x] Editor issue for sub-buttons in some cases
- [x] Tap_action fix
- [x] Pop-up layout fixed
- [x] Info text in switch editor with covers and input_number
- [x] Viewport moves to top before opening popup #458
- [x] Added a visual feedback on sub-buttons
- [x] The feedback on buttons is not triggered when taping a sub-button
- [x] Scroll to close not working anymore (added a new slide effect starting from the header)
- [x] Glitch slider old iPad (seems fixed)
- [x] Fix when the sidebar is hidden broken #453
- [x] If a pop-up has no header I will render it fully, or partially
- [x] Pop-up bg background can't be a variable of a theme
- [x] Sub-buttons issue (unable to reproduce but fixed an issue with the delete button): https://www.reddit.com/r/homeassistant/comments/1c39b1t/comment/kzoffff/?utm_source=share&utm_medium=web3x&utm_name=web3xcss&utm_term=1&utm_content=share_button
- [x] t would be nice to have an option to always open the pop-up at the top. If I open a pop-up and scroll down, then close it and then reopen it, the pop-up is still at the bottom position.
- [x] Performance improvement: add transition-delay to backdrop #456
- [x] Back Button not working, Popups not closing #448
- [x] HBS state error #450
- [x] HBS padding error #452
- [x] Issue on mobile when I have a Thermostat card in the Vertical Stack - it looks like my Thermostat card is messing with the width of the popup, causing all of my buttons to bleed off the side of the screen. (Unable to replicate, is this issue was only happening on previous versions?)
Clooos added a commit that referenced this issue Apr 25, 2024
- [ ] README update for v2
- [x] For media player volume, showing the percentage on the slider
- [x] Possibility to disable the text autoscroll
- [x] Sub-buttons dom changing every hass updates?
- [x] Default actions sub-buttons
- [x] Chromecast fix (working?)
- [x] Re-adding the previous scroll to close for the pop-ups
- [x] The horizontal buttons start in the middle to the right and can‘t be moved, like you can on a mobile (using the vertical layout-card)
- [x] relative_time.ts:19 Uncaught RangeError: Value need to be finite number for Intl.RelativeTimeFormat.prototype.format() at RelativeTimeFormat.format (<anonymous>)
- [x] I have the template Helper which counts lights open separately, and I can see it updates without any problems. But not in the bubble card?
- [x] Slider that keeps scrolling on desktop
- [x] HBS padding fix issue? (Waiting for feedback)
- [x] Additional info. I have enabled the fix when sidebar is hidden. As soon as I disable it all horizontal buttons disappear… (Fixed and there is no need to add the fix anymore, on pop-ups too)
- [x] Default icons for (almost?) everything
- [x] With button_type slider the icon always shows a closed cover.
- [x] Editor issue for sub-buttons in some cases
- [x] Tap_action fix
- [x] Pop-up layout fixed
- [x] Info text in switch editor with covers and input_number
- [x] Viewport moves to top before opening popup #458
- [x] Added a visual feedback on sub-buttons
- [x] The feedback on buttons is not triggered when taping a sub-button
- [x] Scroll to close not working anymore (added a new slide effect starting from the header)
- [x] Glitch slider old iPad (seems fixed)
- [x] Fix when the sidebar is hidden broken #453
- [x] If a pop-up has no header I will render it fully, or partially
- [x] Pop-up bg background can't be a variable of a theme
- [x] Sub-buttons issue (unable to reproduce but fixed an issue with the delete button): https://www.reddit.com/r/homeassistant/comments/1c39b1t/comment/kzoffff/?utm_source=share&utm_medium=web3x&utm_name=web3xcss&utm_term=1&utm_content=share_button
- [x] t would be nice to have an option to always open the pop-up at the top. If I open a pop-up and scroll down, then close it and then reopen it, the pop-up is still at the bottom position.
- [x] Performance improvement: add transition-delay to backdrop #456
- [x] Back Button not working, Popups not closing #448
- [x] HBS state error #450
- [x] HBS padding error #452
- [x] Issue on mobile when I have a Thermostat card in the Vertical Stack - it looks like my Thermostat card is messing with the width of the popup, causing all of my buttons to bleed off the side of the screen. (Unable to replicate, is this issue was only happening on previous versions?)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants