Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Data-Types.md #5

Merged
merged 1 commit into from Jul 19, 2019
Merged

Update Data-Types.md #5

merged 1 commit into from Jul 19, 2019

Conversation

KnapSac
Copy link
Contributor

@KnapSac KnapSac commented Jul 19, 2019

Replaced XLCellValues with XLDataType

Replaced XLCellValues with XLDataType
@igitur
Copy link
Member

igitur commented Jul 19, 2019

Thanks. Our wiki is indeed overdue for a refresh.

@igitur igitur merged commit 52d44e3 into ClosedXML:master Jul 19, 2019
@KnapSac
Copy link
Contributor Author

KnapSac commented Jul 20, 2019

I remember reading something about a homepage in an issue somewhere, have you started on that yet? Otherwise I would be more than happy to help out. Same goes for the rest of the wiki.

@igitur
Copy link
Member

igitur commented Jul 22, 2019

@KnapSac Yes, I want to move to https://closedxml.readthedocs.io (currently empty). But it's not just a question of migrating the existing wiki. I think it needs a total rethink and rewrite of the articles (with proper categorisation and logical flow from step to step). Here's an example of good documentation on readthedocs.io: https://topshelf.readthedocs.io

@igitur
Copy link
Member

igitur commented Jul 22, 2019

If you want to help with this, I can give you access to the readthedocs account and you can start with a proof of concept. Will be much appreciated.

@KnapSac
Copy link
Contributor Author

KnapSac commented Jul 22, 2019

Absolutely, I can start on a proof of concept some time this week.

@igitur
Copy link
Member

igitur commented Jul 22, 2019

Ok, so I read the RTD documentation. RTD is quite closely integrated with the ClosedXML main Github repository. So for you to continue, clone and branch https://github.com/ClosedXML/ClosedXML, create a /docs directory and start adding the documentation there. Commit your documentation and log a PR on the main ClosedXML repository. More info at https://docs.readthedocs.io/en/latest/getting_started.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants