Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DocumentFormat.OpenXml dependency to 2.16.0 #1675

Merged
merged 2 commits into from
Jun 8, 2022

Conversation

twsouthwick
Copy link
Contributor

This adds support up through Office 2019, as well brings a ton of performance/threading fixes under the covers.

@igitur
Copy link
Member

igitur commented Jun 9, 2021

Thanks, @twsouthwick . We'd been deliberately avoid a forced upgrade of OpenXML until we required something new in the API, but I think it's becoming clear that the performance improvements make it worth it. The upgrade breaks some tests, which I fixed in 67ad81c.

@igitur
Copy link
Member

igitur commented Jun 9, 2021

@Pankraty You OK with forcing the upgrade? We'll have to do it for #1619 anyway.

@Pankraty
Copy link
Member

I agree

@igitur igitur added the enhancement Feature already exists, but should be enahanced. label Jun 10, 2021
@igitur igitur added this to the v0.96 milestone Jun 10, 2021
@rominator1983
Copy link
Contributor

rominator1983 commented Feb 18, 2022

in the meantime you can check out https://github.com/stesee/ClosedXML where there is an up to date version of DocumentFormat.OpenXml in place

@Havunen
Copy link

Havunen commented Feb 25, 2022

Yeah its already 2.15.0 https://www.nuget.org/packages/DocumentFormat.OpenXml/

@rominator1983
Copy link
Contributor

rominator1983 commented Feb 25, 2022 via email

@igitur
Copy link
Member

igitur commented Jun 8, 2022

Reviving this.

@jahav @Pankraty We might as well just jump straight to Document.OpenXml v2.16.0 (latest stable release at time of writing)?

@igitur igitur changed the title Update DocumentFormat.OpenXml dependency to 2.13.0 Update DocumentFormat.OpenXml dependency to 2.16.0 Jun 8, 2022
@igitur igitur merged commit bdfec53 into ClosedXML:develop Jun 8, 2022
@igitur
Copy link
Member

igitur commented Jun 8, 2022

Thanks @twsouthwick. Sorry for the long wait to merge this.

@twsouthwick twsouthwick deleted the move-to-2.13.0 branch June 10, 2022 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature already exists, but should be enahanced.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants