Renamed XLPivotValues parameters #1946
Conversation
There was a problem hiding this comment.
Interface IXLPivotValues also needs to have signatures changed.
PivotValueFieldReference needs to have a diferent value in ctor. It wuld fail later in some edge cases, because it uses pt.Values.IndexOf(Value.ToString()) where Value is a SourceName (at least when I looked through call graph).
The AbstractPivotFieldReference.Match method of the is later used for pivot table table styling IIRC, https://github.com/ClosedXML/ClosedXML/wiki/Pivot-Table-Styles#cross-of-values-and-axis-fields
|
Thanks for the guidance @jahav |
…ing with the pivot values, because there can be multiple value fields for the same source name (e.g. avg and sum of the same source).
…d (e.g. sum of a Filed or a average of a field) and therefore PivotValueFieldReference should use CustomName to find the correct pivot value field, not SourceName.
|
Thanks for the contribution. Pivot tables will likely get some TLC in 0.102. That |
|
Pivot tables do need some work, but have also come a long way in a short time, before dev paused. I'd suggest the next big step is to factor out common pivot table data sources, because multiple pivot tables can reference a single source and changes to a source affect all dependent pivot tables. Also see related issue at dotnet/Open-XML-SDK#612 |
Fixes #1945